]> Git Repo - linux.git/commitdiff
batman-adv: Use netif_rx_any_context().
authorSebastian Andrzej Siewior <[email protected]>
Sat, 13 Feb 2021 17:02:04 +0000 (18:02 +0100)
committerSimon Wunderlich <[email protected]>
Sat, 13 Feb 2021 17:08:40 +0000 (18:08 +0100)
The usage of in_interrupt() in non-core code is phased out. Ideally the
information of the calling context should be passed by the callers or the
functions be split as appropriate.

The attempt to consolidate the code by passing an arguemnt or by
distangling it failed due lack of knowledge about this driver and because
the call chains are hard to follow.

As a stop gap use netif_rx_any_context() which invokes the correct code path
depending on context and confines the in_interrupt() usage to core code.

Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Signed-off-by: Sven Eckelmann <[email protected]>
Signed-off-by: Simon Wunderlich <[email protected]>
net/batman-adv/bridge_loop_avoidance.c

index 360bdbf447488d2ca10d5741476713bebfd5bb5c..bcd543ce835b49480613a24108eb6a2ba62657e5 100644 (file)
@@ -438,10 +438,7 @@ static void batadv_bla_send_claim(struct batadv_priv *bat_priv, u8 *mac,
        batadv_add_counter(bat_priv, BATADV_CNT_RX_BYTES,
                           skb->len + ETH_HLEN);
 
-       if (in_interrupt())
-               netif_rx(skb);
-       else
-               netif_rx_ni(skb);
+       netif_rx_any_context(skb);
 out:
        if (primary_if)
                batadv_hardif_put(primary_if);
This page took 0.06667 seconds and 4 git commands to generate.