]> Git Repo - linux.git/commitdiff
dmaengine: xilinx_dma: Remove __aligned attribute on zynqmp_dma_desc_ll
authorNathan Chancellor <[email protected]>
Thu, 25 Oct 2018 18:05:25 +0000 (11:05 -0700)
committerVinod Koul <[email protected]>
Sat, 24 Nov 2018 13:41:20 +0000 (19:11 +0530)
Clang warns:

drivers/dma/xilinx/zynqmp_dma.c:166:4: warning: attribute 'aligned' is
ignored, place it after "struct" to apply attribute to type declaration
[-Wignored-attributes]
}; __aligned(64)
   ^
./include/linux/compiler_types.h:200:38: note: expanded from macro
'__aligned'
                                               ^
1 warning generated.

As Nick pointed out in the previous version of this patch, the author
likely intended for this struct to be 8-byte (64-bit) aligned, not
64-byte, which is the default. Remove the hanging __aligned attribute.

Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver support")
Reported-by: Nick Desaulniers <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Vinod Koul <[email protected]>
drivers/dma/xilinx/zynqmp_dma.c

index c74a88b650396e34cb713e069ffb4640060d94f8..73de6a6179fcd106f7fbaff8de4cede47304f665 100644 (file)
@@ -163,7 +163,7 @@ struct zynqmp_dma_desc_ll {
        u32 ctrl;
        u64 nxtdscraddr;
        u64 rsvd;
-}; __aligned(64)
+};
 
 /**
  * struct zynqmp_dma_desc_sw - Per Transaction structure
This page took 0.056313 seconds and 4 git commands to generate.