cifs: log session id when a matching ses is not found

We do not log the session id in crypt_setup when a matching
session is not found. Printing the session id helps debugging
here. This change does just that.

This change also changes this log to FYI, since it is normal to
see then during a reconnect. Doing the same for a similar log
in case of signed connections.

The plan is to have a tracepoint for this event, so that we will
be able to see this event if need be. That will be done as
another change.

Signed-off-by: Shyam Prasad N <[email protected]>
Signed-off-by: Steve French <[email protected]>

diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
index 3696d4ce0df3393d1920aabe32523bff7952d83e..7f8e07c42d4c83ba1e68ee7fde71edb57da1d2e7 100644 (file)
--- a/fs/smb/client/smb2ops.c
+++ b/fs/smb/client/smb2ops.c
@@ -4444,8 +4444,8 @@ crypt_message(struct TCP_Server_Info *server, int num_rqst,
 
        rc = smb2_get_enc_key(server, le64_to_cpu(tr_hdr->SessionId), enc, key);
        if (rc) {
-               cifs_server_dbg(VFS, "%s: Could not get %scryption key\n", __func__,
-                        enc ? "en" : "de");
+               cifs_server_dbg(FYI, "%s: Could not get %scryption key. sid: 0x%llx\n", __func__,
+                        enc ? "en" : "de", le64_to_cpu(tr_hdr->SessionId));
                return rc;
        }
 

diff --git a/fs/smb/client/smb2transport.c b/fs/smb/client/smb2transport.c
index 22954a9c7a6c7633f8a48422b98b57291c06843e..c3e9cb5c7be5e926367eeab7e7694d1284e08b86 100644 (file)
--- a/fs/smb/client/smb2transport.c
+++ b/fs/smb/client/smb2transport.c
@@ -92,7 +92,7 @@ int smb2_get_sign_key(__u64 ses_id, struct TCP_Server_Info *server, u8 *key)
                if (ses->Suid == ses_id)
                        goto found;
        }
-       cifs_server_dbg(VFS, "%s: Could not find session 0x%llx\n",
+       cifs_server_dbg(FYI, "%s: Could not find session 0x%llx\n",
                        __func__, ses_id);
        rc = -ENOENT;
        goto out;
@@ -564,7 +564,7 @@ smb3_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server,
 
        rc = smb2_get_sign_key(le64_to_cpu(shdr->SessionId), server, key);
        if (unlikely(rc)) {
-               cifs_server_dbg(VFS, "%s: Could not get signing key\n", __func__);
+               cifs_server_dbg(FYI, "%s: Could not get signing key\n", __func__);
                return rc;
        }