]> Git Repo - linux.git/commitdiff
fpga: disable KUnit test suites when module support is enabled
authorMarco Pagani <[email protected]>
Wed, 18 Oct 2023 16:38:13 +0000 (18:38 +0200)
committerGreg Kroah-Hartman <[email protected]>
Sat, 21 Oct 2023 10:31:25 +0000 (12:31 +0200)
The fpga core currently assumes that all manager, bridge, and region
devices have a parent device associated with a driver that can be used
to take the module's refcount. This behavior causes the fpga test suites
to crash with a null-ptr-deref since parent fake devices do not have a
driver. This patch disables all fpga KUnit test suites when loadable
module support is enabled until the fpga core is fixed. Test suites
can still be run using the KUnit default UML kernel.

Signed-off-by: Marco Pagani <[email protected]>
Acked-by: Xu Yilun <[email protected]>
Fixes: ccbc1c302115 ("fpga: add an initial KUnit suite for the FPGA Manager")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
drivers/fpga/tests/Kconfig

index e4a64815f16d63b054d1f7f706b1abf349b7a8e7..d4e55204c092671b31a621a14fcbd7d93d819c1c 100644 (file)
@@ -1,6 +1,6 @@
 config FPGA_KUNIT_TESTS
-       tristate "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
-       depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT=y
+       bool "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
+       depends on FPGA=y && FPGA_REGION=y && FPGA_BRIDGE=y && KUNIT=y && MODULES=n
        default KUNIT_ALL_TESTS
         help
           This builds unit tests for the FPGA subsystem
This page took 0.056481 seconds and 4 git commands to generate.