]> Git Repo - linux.git/commitdiff
drm: msm: Fix add_gpu_components
authorJeffrey Hugo <[email protected]>
Wed, 26 Jun 2019 18:00:15 +0000 (11:00 -0700)
committerSean Paul <[email protected]>
Thu, 1 Aug 2019 16:52:21 +0000 (12:52 -0400)
add_gpu_components() adds found GPU nodes from the DT to the match list,
regardless of the status of the nodes.  This is a problem, because if the
nodes are disabled, they should not be on the match list because they will
not be matched.  This prevents display from initing if a GPU node is
defined, but it's status is disabled.

Fix this by checking the node's status before adding it to the match list.

Fixes: dc3ea265b856 (drm/msm: Drop the gpu binding)
Reviewed-by: Rob Clark <[email protected]>
Signed-off-by: Jeffrey Hugo <[email protected]>
Signed-off-by: Sean Paul <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
drivers/gpu/drm/msm/msm_drv.c

index c226156f2dea8d28948c0056ed02974823974b46..c356f5ccf25360627a62e0e3feb89f7511cbc8fd 100644 (file)
@@ -1279,7 +1279,8 @@ static int add_gpu_components(struct device *dev,
        if (!np)
                return 0;
 
-       drm_of_component_match_add(dev, matchptr, compare_of, np);
+       if (of_device_is_available(np))
+               drm_of_component_match_add(dev, matchptr, compare_of, np);
 
        of_node_put(np);
 
This page took 0.069087 seconds and 4 git commands to generate.