platform/x86: system76_acpi: Fix input device error handling

Users on darp6 that do not have Open EC firmware have reported crashes
on boot. Correct the error handling for the input device to fix it.

Managed devices do not need to be explicitly unregistered or freed, as
this is handled by devres. Drop the call to input_free_device.

Fixes: 0de30fc684b3 ("platform/x86: system76_acpi: Replace Fn+F2 function for OLED models")
Signed-off-by: Tim Crawford <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Hans de Goede <[email protected]>

diff --git a/drivers/platform/x86/system76_acpi.c b/drivers/platform/x86/system76_acpi.c
index b3c8178420b1a756b3ee3866569340260e232751..8b292ee95a1448f3637fbeb887b557c009836e7e 100644 (file)
--- a/drivers/platform/x86/system76_acpi.c
+++ b/drivers/platform/x86/system76_acpi.c
@@ -739,7 +739,6 @@ static int system76_add(struct acpi_device *acpi_dev)
 error:
        kfree(data->ntmp);
        kfree(data->nfan);
-       input_free_device(data->input);
        return err;
 }