rtc: stk17ta8: fix possible race condition

The probe function is not allowed to fail after registering the RTC. Call
rtc_register_device() at the end.

Signed-off-by: Alexandre Belloni <[email protected]>

diff --git a/drivers/rtc/rtc-stk17ta8.c b/drivers/rtc/rtc-stk17ta8.c
index f936accf622f790c080e3ceeb3d5ef0dc93d155e..1d6febbe7d3977cc9f303974f61d1dab8721e488 100644 (file)
--- a/drivers/rtc/rtc-stk17ta8.c
+++ b/drivers/rtc/rtc-stk17ta8.c
@@ -334,11 +334,11 @@ static int stk17ta8_rtc_probe(struct platform_device *pdev)
 
        pdata->rtc->ops = &stk17ta8_rtc_ops;
 
-       ret = rtc_register_device(pdata->rtc);
+       ret = sysfs_create_bin_file(&pdev->dev.kobj, &stk17ta8_nvram_attr);
        if (ret)
                return ret;
 
-       ret = sysfs_create_bin_file(&pdev->dev.kobj, &stk17ta8_nvram_attr);
+       ret = rtc_register_device(pdata->rtc);
 
        return ret;
 }