]> Git Repo - linux.git/commitdiff
scsi: ufs: core: Simplify temperature exception event handling
authorAvri Altman <[email protected]>
Tue, 14 Jan 2025 18:12:05 +0000 (20:12 +0200)
committerMartin K. Petersen <[email protected]>
Tue, 21 Jan 2025 17:20:45 +0000 (12:20 -0500)
This commit simplifies the temperature exception event handling by removing
the ufshcd_temp_exception_event_handler() function and directly calling
ufs_hwmon_notify_event() in ufshcd_exception_event_handler().

The ufshcd_temp_exception_event_handler() function contained a placeholder
comment for platform vendors to add additional steps if required. However,
since its introduction a few years ago, no vendor has added any additional
steps. Therefore, the placeholder function is removed to streamline the
code.

Signed-off-by: Avri Altman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Bean Huo <[email protected]>
Reviewed-by: Bart Van Assche <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
drivers/ufs/core/ufshcd.c

index 0920a443588c244c75c76797d0ec7bd067de9146..f6c38cf10382064ed78ba4b11c6b19a92803796c 100644 (file)
@@ -5976,24 +5976,6 @@ out:
                                __func__, err);
 }
 
-static void ufshcd_temp_exception_event_handler(struct ufs_hba *hba, u16 status)
-{
-       u32 value;
-
-       if (ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_READ_ATTR,
-                               QUERY_ATTR_IDN_CASE_ROUGH_TEMP, 0, 0, &value))
-               return;
-
-       dev_info(hba->dev, "exception Tcase %d\n", value - 80);
-
-       ufs_hwmon_notify_event(hba, status & MASK_EE_URGENT_TEMP);
-
-       /*
-        * A placeholder for the platform vendors to add whatever additional
-        * steps required
-        */
-}
-
 static int __ufshcd_wb_toggle(struct ufs_hba *hba, bool set, enum flag_idn idn)
 {
        u8 index;
@@ -6214,7 +6196,7 @@ static void ufshcd_exception_event_handler(struct work_struct *work)
                ufshcd_bkops_exception_event_handler(hba);
 
        if (status & hba->ee_drv_mask & MASK_EE_URGENT_TEMP)
-               ufshcd_temp_exception_event_handler(hba, status);
+               ufs_hwmon_notify_event(hba, status & MASK_EE_URGENT_TEMP);
 
        ufs_debugfs_exception_event(hba, status);
 }
This page took 0.074145 seconds and 4 git commands to generate.