]> Git Repo - linux.git/commitdiff
crypto: lib - remove unneeded selection of XOR_BLOCKS
authorEric Biggers <[email protected]>
Fri, 26 Aug 2022 05:04:56 +0000 (22:04 -0700)
committerHerbert Xu <[email protected]>
Fri, 26 Aug 2022 10:40:14 +0000 (18:40 +0800)
CRYPTO_LIB_CHACHA_GENERIC doesn't need to select XOR_BLOCKS.  It perhaps
was thought that it's needed for __crypto_xor, but that's not the case.

Enabling XOR_BLOCKS is problematic because the XOR_BLOCKS code runs a
benchmark when it is initialized.  That causes a boot time regression on
systems that didn't have it enabled before.

Therefore, remove this unnecessary and problematic selection.

Fixes: e56e18985596 ("lib/crypto: add prompts back to crypto libraries")
Cc: [email protected]
Signed-off-by: Eric Biggers <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
lib/crypto/Kconfig

index 9ff549f63540fa3a586382f89d8fcf3886c0940b..47816af9a9d7e111bf411bc886820bc8cf0cfe53 100644 (file)
@@ -33,7 +33,6 @@ config CRYPTO_ARCH_HAVE_LIB_CHACHA
 
 config CRYPTO_LIB_CHACHA_GENERIC
        tristate
-       select XOR_BLOCKS
        help
          This symbol can be depended upon by arch implementations of the
          ChaCha library interface that require the generic code as a
This page took 0.050075 seconds and 4 git commands to generate.