backlight: lm3639: Unconditionally call led_classdev_unregister

Clang warns that the address of a pointer will always evaluated as true
in a boolean context.

drivers/video/backlight/lm3639_bl.c:403:14: warning: address of
'pchip->cdev_torch' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (&pchip->cdev_torch)
        ~~   ~~~~~~~^~~~~~~~~~
drivers/video/backlight/lm3639_bl.c:405:14: warning: address of
'pchip->cdev_flash' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (&pchip->cdev_flash)
        ~~   ~~~~~~~^~~~~~~~~~
2 warnings generated.

These statements have been present since 2012, introduced by
commit 0f59858d5119 ("backlight: add new lm3639 backlight
driver"). Given that they have been called unconditionally since
then presumably without any issues, removing the always true if
statements to fix the warnings without any real world changes.

Link: https://github.com/ClangBuiltLinux/linux/issues/119
Signed-off-by: Nathan Chancellor <[email protected]>
Reviewed-by: Daniel Thompson <[email protected]>
Signed-off-by: Lee Jones <[email protected]>

diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
index cd50df5807eadb2b4bf18b6fa8efc906beda0dee..086611c7bc03cf3505bbe7e041dc6419841f30f9 100644 (file)
--- a/drivers/video/backlight/lm3639_bl.c
+++ b/drivers/video/backlight/lm3639_bl.c
@@ -400,10 +400,8 @@ static int lm3639_remove(struct i2c_client *client)
 
        regmap_write(pchip->regmap, REG_ENABLE, 0x00);
 
-       if (&pchip->cdev_torch)
-               led_classdev_unregister(&pchip->cdev_torch);
-       if (&pchip->cdev_flash)
-               led_classdev_unregister(&pchip->cdev_flash);
+       led_classdev_unregister(&pchip->cdev_torch);
+       led_classdev_unregister(&pchip->cdev_flash);
        if (pchip->bled)
                device_remove_file(&(pchip->bled->dev), &dev_attr_bled_mode);
        return 0;