]> Git Repo - linux.git/commitdiff
of: iommu: Silence misleading warning
authorRobin Murphy <[email protected]>
Wed, 22 Jul 2015 17:47:00 +0000 (18:47 +0100)
committerJoerg Roedel <[email protected]>
Mon, 3 Aug 2015 14:07:49 +0000 (16:07 +0200)
Printing "IOMMU is currently not supported for PCI" for
every PCI device probed on a DT-based system proves to be
both irritatingly noisy and confusing to users who have
misinterpreted it to mean they can no longer use VFIO device
assignment.

Since configuring DMA masks for PCI devices via
of_dma_configure() has not in fact changed anything with
regard to IOMMUs there really is nothing to warn about here;
shut it up.

Signed-off-by: Robin Murphy <[email protected]>
Acked-by: Marc Zyngier <[email protected]>
Signed-off-by: Joerg Roedel <[email protected]>
drivers/iommu/of_iommu.c

index 43429ab62228a4d0674dadeab740be812af77ff8..60ba238090d92f3eed93de994d5fd7271a68b8ce 100644 (file)
@@ -141,10 +141,12 @@ struct iommu_ops *of_iommu_configure(struct device *dev,
        struct iommu_ops *ops = NULL;
        int idx = 0;
 
-       if (dev_is_pci(dev)) {
-               dev_err(dev, "IOMMU is currently not supported for PCI\n");
+       /*
+        * We can't do much for PCI devices without knowing how
+        * device IDs are wired up from the PCI bus to the IOMMU.
+        */
+       if (dev_is_pci(dev))
                return NULL;
-       }
 
        /*
         * We don't currently walk up the tree looking for a parent IOMMU.
This page took 0.054421 seconds and 4 git commands to generate.