]> Git Repo - linux.git/commitdiff
drm/mipi: use dcs write for mipi_dsi_dcs_set_tear_scanline
authorEmil Velikov <[email protected]>
Tue, 5 May 2020 16:03:29 +0000 (17:03 +0100)
committerSam Ravnborg <[email protected]>
Mon, 29 Jun 2020 07:45:15 +0000 (09:45 +0200)
The helper uses the MIPI_DCS_SET_TEAR_SCANLINE, although it's currently
using the generic write. This does not look right.

Perhaps some platforms don't distinguish between the two writers?

Cc: Robert Chiras <[email protected]>
Cc: Vinay Simha BN <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Thierry Reding <[email protected]>
Fixes: e83950816367 ("drm/dsi: Implement set tear scanline")
Signed-off-by: Emil Velikov <[email protected]>
Reviewed-by: Thierry Reding <[email protected]>
Signed-off-by: Sam Ravnborg <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
drivers/gpu/drm/drm_mipi_dsi.c

index b96d5b4629d7bb94100ae8609f3094ca6fa1d2c7..07102d8da58fdd8c0a4b36cd1157ced6ed10d8c2 100644 (file)
@@ -1082,11 +1082,11 @@ EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format);
  */
 int mipi_dsi_dcs_set_tear_scanline(struct mipi_dsi_device *dsi, u16 scanline)
 {
-       u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, scanline >> 8,
-                         scanline & 0xff };
+       u8 payload[2] = { scanline >> 8, scanline & 0xff };
        ssize_t err;
 
-       err = mipi_dsi_generic_write(dsi, payload, sizeof(payload));
+       err = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_TEAR_SCANLINE, payload,
+                                sizeof(payload));
        if (err < 0)
                return err;
 
This page took 0.145308 seconds and 4 git commands to generate.