Smack: correct final mmap check comparison

The mmap policy enforcement checks the access of the
SMACK64MMAP subject against the current subject incorrectly.
The check as written works correctly only if the access
rules involved have the same access. This is the common
case, so initial testing did not find a problem.

Signed-off-by: Casey Schaufler <[email protected]>

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 92cb71507f5ba0f1c03aeeac2e72043710378d66..5ab3f39442f2bc4d4b5bf55656997f06450ca69d 100644 (file)
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -1218,7 +1218,7 @@ static int smack_file_mmap(struct file *file,
                 * not available to a SMACK64MMAP subject
                 * deny access.
                 */
-               if ((may | mmay) != may) {
+               if ((may | mmay) != mmay) {
                        rc = -EACCES;
                        break;
                }