]> Git Repo - linux.git/commitdiff
bus: bt1-apb: Use PTR_ERR_OR_ZERO to return from request-regs method
authorSerge Semin <[email protected]>
Thu, 28 May 2020 14:50:47 +0000 (17:50 +0300)
committerArnd Bergmann <[email protected]>
Thu, 28 May 2020 14:56:46 +0000 (16:56 +0200)
Indeed it's more optimal to use the PTR_ERR_OR_ZERO() macro there instead
of having two return points.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Serge Semin <[email protected]>
Cc: Alexey Malahov <[email protected]>
Cc: Olof Johansson <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: [email protected]
Signed-off-by: Arnd Bergmann <[email protected]>
drivers/bus/bt1-apb.c

index 59ec5e7077e8900ec92fea57de1b298f3bd2cd22..7e57fc2af745878fb8abdb40a8d9fb891aecd3fe 100644 (file)
@@ -164,12 +164,10 @@ static int bt1_apb_request_regs(struct bt1_apb *apb)
        }
 
        apb->res = devm_platform_ioremap_resource_byname(pdev, "nodev");
-       if (IS_ERR(apb->res)) {
+       if (IS_ERR(apb->res))
                dev_err(apb->dev, "Couldn't map reserved region\n");
-               return PTR_ERR(apb->res);
-       }
 
-       return 0;
+       return PTR_ERR_OR_ZERO(apb->res);
 }
 
 static int bt1_apb_request_rst(struct bt1_apb *apb)
This page took 0.054766 seconds and 4 git commands to generate.