]> Git Repo - linux.git/commitdiff
hwmon: (asus_atk0110) Use str_enabled_disabled() and str_enable_disable() helpers
authorThorsten Blum <[email protected]>
Sun, 12 Jan 2025 10:51:28 +0000 (11:51 +0100)
committerGuenter Roeck <[email protected]>
Sun, 12 Jan 2025 16:46:23 +0000 (08:46 -0800)
Remove hard-coded strings by using the str_enabled_disabled() and
str_enable_disable() helper functions.

Signed-off-by: Thorsten Blum <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
[groeck: Fixed subject and continuation line alignments]
Signed-off-by: Guenter Roeck <[email protected]>
drivers/hwmon/asus_atk0110.c

index 1dc7e24fe4c5ef05fc390c8cf5658fe48d09413e..c80350e499e97061c845a8a95fa4d597c079e6db 100644 (file)
@@ -17,6 +17,7 @@
 #include <linux/jiffies.h>
 #include <linux/err.h>
 #include <linux/acpi.h>
+#include <linux/string_choices.h>
 
 #define ATK_HID "ATK0110"
 
@@ -441,7 +442,7 @@ static void atk_print_sensor(struct atk_data *data, union acpi_object *obj)
                        flags->integer.value,
                        name->string.pointer,
                        limit1->integer.value, limit2->integer.value,
-                       enable->integer.value ? "enabled" : "disabled");
+                       str_enabled_disabled(enable->integer.value));
 #endif
 }
 
@@ -1074,8 +1075,7 @@ static int atk_ec_enabled(struct atk_data *data)
                err = -EIO;
        } else {
                err = (buf->value != 0);
-               dev_dbg(dev, "EC is %sabled\n",
-                               err ? "en" : "dis");
+               dev_dbg(dev, "EC is %s\n", str_enabled_disabled(err));
        }
 
        ACPI_FREE(obj);
@@ -1096,18 +1096,15 @@ static int atk_ec_ctl(struct atk_data *data, int enable)
 
        obj = atk_sitm(data, &sitm);
        if (IS_ERR(obj)) {
-               dev_err(dev, "Failed to %sable the EC\n",
-                               enable ? "en" : "dis");
+               dev_err(dev, "Failed to %s the EC\n", str_enable_disable(enable));
                return PTR_ERR(obj);
        }
        ec_ret = (struct atk_acpi_ret_buffer *)obj->buffer.pointer;
        if (ec_ret->flags == 0) {
-               dev_err(dev, "Failed to %sable the EC\n",
-                               enable ? "en" : "dis");
+               dev_err(dev, "Failed to %s the EC\n", str_enable_disable(enable));
                err = -EIO;
        } else {
-               dev_info(dev, "EC %sabled\n",
-                               enable ? "en" : "dis");
+               dev_info(dev, "EC %s\n", str_enabled_disabled(enable));
        }
 
        ACPI_FREE(obj);
This page took 0.060945 seconds and 4 git commands to generate.