csky: syscache: Fixup duplicate cache flush

The current csky logic of sys_cacheflush is wrong, it'll cause
icache flush call dcache flush again. Now fixup it with a
conditional "break & fallthrough".

Fixes: 997153b9a75c ("csky: Add flush_icache_mm to defer flush icache all")
Fixes: 0679d29d3e23 ("csky: fix syscache.c fallthrough warning")
Acked-by: Randy Dunlap <[email protected]>
Co-Developed-by: Randy Dunlap <[email protected]>
Signed-off-by: Guo Ren <[email protected]>
Cc: Arnd Bergmann <[email protected]>

diff --git a/arch/csky/mm/syscache.c b/arch/csky/mm/syscache.c
index 4e51d63850c462e75253a43cb657e31894f847ba..cd847ad62c7ee4ccd45207473d118846afe432f3 100644 (file)
--- a/arch/csky/mm/syscache.c
+++ b/arch/csky/mm/syscache.c
@@ -12,15 +12,17 @@ SYSCALL_DEFINE3(cacheflush,
                int, cache)
 {
        switch (cache) {
-       case ICACHE:
        case BCACHE:
-               flush_icache_mm_range(current->mm,
-                               (unsigned long)addr,
-                               (unsigned long)addr + bytes);
-               fallthrough;
        case DCACHE:
                dcache_wb_range((unsigned long)addr,
                                (unsigned long)addr + bytes);
+               if (cache != BCACHE)
+                       break;
+               fallthrough;
+       case ICACHE:
+               flush_icache_mm_range(current->mm,
+                               (unsigned long)addr,
+                               (unsigned long)addr + bytes);
                break;
        default:
                return -EINVAL;