openvswitch: use after free in __ovs_ct_free_action()

We free "ct_info->ct" and then use it on the next line when we pass it
to nf_ct_destroy_timeout().  This patch swaps the order to avoid the use
after free.

Fixes: 06bd2bdf19d2 ("openvswitch: Add timeout support to ct action")
Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Yi-Hung Wei <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index 121b01d4a3c0700f4427f192f28c103806cb2c81..0be3ab5bde26e43e2291aeb9180167efb7fede5e 100644 (file)
--- a/net/openvswitch/conntrack.c
+++ b/net/openvswitch/conntrack.c
@@ -1804,9 +1804,9 @@ static void __ovs_ct_free_action(struct ovs_conntrack_info *ct_info)
        if (ct_info->helper)
                nf_conntrack_helper_put(ct_info->helper);
        if (ct_info->ct) {
-               nf_ct_tmpl_free(ct_info->ct);
                if (ct_info->timeout[0])
                        nf_ct_destroy_timeout(ct_info->ct);
+               nf_ct_tmpl_free(ct_info->ct);
        }
 }