usb: dwc3: gadget: Prevent repeat pullup()

Don't do soft-disconnect if it's previously done. Likewise, don't do
soft-connect if the device is currently connected and running. It would
break normal operation.

Currently the caller of pullup() (udc's sysfs soft_connect) only checks
if it had initiated disconnect to prevent repeating soft-disconnect. It
doesn't check for soft-connect. To be safe, let's keep the check here
regardless whether the udc core is fixed.

Signed-off-by: Thinh Nguyen <[email protected]>
Link: https://lore.kernel.org/r/1c1345bd66c97a9d32f77d63aaadd04b7b037143.1650593829.git.Thinh.Nguyen@synopsys.com
Signed-off-by: Greg Kroah-Hartman <[email protected]>

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 5b1d79528da373aee9943ff052dbc80fa1c81775..e9c992be847240ef14ba4f18802e9506c406f426 100644 (file)
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2514,6 +2514,10 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on)
        int                     ret;
 
        is_on = !!is_on;
+
+       if (dwc->pullups_connected == is_on)
+               return 0;
+
        dwc->softconnect = is_on;
        /*
         * Per databook, when we want to stop the gadget, if a control transfer