]> Git Repo - linux.git/commitdiff
net: hns3: fix missing features due to dev->features configuration too early
authorHao Lan <[email protected]>
Fri, 25 Oct 2024 09:29:33 +0000 (17:29 +0800)
committerPaolo Abeni <[email protected]>
Thu, 31 Oct 2024 10:15:42 +0000 (11:15 +0100)
Currently, the netdev->features is configured in hns3_nic_set_features.
As a result, __netdev_update_features considers that there is no feature
difference, and the procedures of the real features are missing.

Fixes: 2a7556bb2b73 ("net: hns3: implement ndo_features_check ops for hns3 driver")
Signed-off-by: Hao Lan <[email protected]>
Signed-off-by: Jian Shen <[email protected]>
Signed-off-by: Jijie Shao <[email protected]>
Signed-off-by: Paolo Abeni <[email protected]>
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

index 8760b4e9ade6b24d763c3cd36b3b54e20b93e3d5..b09f0cca34dc68604dc00b7e7ed233a16fcdadd7 100644 (file)
@@ -2483,7 +2483,6 @@ static int hns3_nic_set_features(struct net_device *netdev,
                        return ret;
        }
 
-       netdev->features = features;
        return 0;
 }
 
This page took 0.049197 seconds and 4 git commands to generate.