sh: intc: Fix use-after-free bug in register_intc_controller()

In the error handling for this function, d is freed without ever
removing it from intc_list which would lead to a use after free.
To fix this, let's only add it to the list after everything has
succeeded.

Fixes: 2dcec7a988a1 ("sh: intc: set_irq_wake() support")
Signed-off-by: Dan Carpenter <[email protected]>
Reviewed-by: John Paul Adrian Glaubitz <[email protected]>
Signed-off-by: John Paul Adrian Glaubitz <[email protected]>

diff --git a/drivers/sh/intc/core.c b/drivers/sh/intc/core.c
index 74350b5871dc8ecf627c6539170872741831436e..ea571eeb307878079e9a015aef4f93a3201920cd 100644 (file)
--- a/drivers/sh/intc/core.c
+++ b/drivers/sh/intc/core.c
@@ -209,7 +209,6 @@ int __init register_intc_controller(struct intc_desc *desc)
                goto err0;
 
        INIT_LIST_HEAD(&d->list);
-       list_add_tail(&d->list, &intc_list);
 
        raw_spin_lock_init(&d->lock);
        INIT_RADIX_TREE(&d->tree, GFP_ATOMIC);
@@ -369,6 +368,7 @@ int __init register_intc_controller(struct intc_desc *desc)
 
        d->skip_suspend = desc->skip_syscore_suspend;
 
+       list_add_tail(&d->list, &intc_list);
        nr_intc_controllers++;
 
        return 0;