r8169: fix rare issue with broken rx after link-down on RTL8125

In very rare cases (I've seen two reports so far about different
RTL8125 chip versions) it seems the MAC locks up when link goes down
and requires a software reset to get revived.
Realtek doesn't publish hw errata information, therefore the root cause
is unknown. Realtek vendor drivers do a full hw re-initialization on
each link-up event, the slimmed-down variant here was reported to fix
the issue for the reporting user.
It's not fully clear which parts of the NIC are reset as part of the
software reset, therefore I can't rule out side effects.

Fixes: f1bce4ad2f1c ("r8169: add support for RTL8125")
Reported-by: Martin Kjær Jørgensen <[email protected]>
Link: https://lore.kernel.org/netdev/[email protected]/T/
Signed-off-by: Heiner Kallweit <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 6351a2dc13bce6ee921ca8f8a6acec9ffb6bfb02..df0df4d09f05717d667bbbc28c639cf2aabefd40 100644 (file)
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -4596,7 +4596,11 @@ static void r8169_phylink_handler(struct net_device *ndev)
        if (netif_carrier_ok(ndev)) {
                rtl_link_chg_patch(tp);
                pm_request_resume(d);
+               netif_wake_queue(tp->dev);
        } else {
+               /* In few cases rx is broken after link-down otherwise */
+               if (rtl_is_8125(tp))
+                       rtl_reset_work(tp);
                pm_runtime_idle(d);
        }