Merge tag 'vfs-6.14-rc1.pidfs' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs

Pull pidfs updates from Christian Brauner:

 - Rework inode number allocation

   Recently we received a patchset that aims to enable file handle
   encoding and decoding via name_to_handle_at(2) and
   open_by_handle_at(2).

   A crucical step in the patch series is how to go from inode number to
   struct pid without leaking information into unprivileged contexts.
   The issue is that in order to find a struct pid the pid number in the
   initial pid namespace must be encoded into the file handle via
   name_to_handle_at(2).

   This can be used by containers using a separate pid namespace to
   learn what the pid number of a given process in the initial pid
   namespace is. While this is a weak information leak it could be used
   in various exploits and in general is an ugly wart in the design.

   To solve this problem a new way is needed to lookup a struct pid
   based on the inode number allocated for that struct pid. The other
   part is to remove the custom inode number allocation on 32bit systems
   that is also an ugly wart that should go away.

   Allocate unique identifiers for struct pid by simply incrementing a
   64 bit counter and insert each struct pid into the rbtree so it can
   be looked up to decode file handles avoiding to leak actual pids
   across pid namespaces in file handles.

   On both 64 bit and 32 bit the same 64 bit identifier is used to
   lookup struct pid in the rbtree. On 64 bit the unique identifier for
   struct pid simply becomes the inode number. Comparing two pidfds
   continues to be as simple as comparing inode numbers.

   On 32 bit the 64 bit number assigned to struct pid is split into two
   32 bit numbers. The lower 32 bits are used as the inode number and
   the upper 32 bits are used as the inode generation number. Whenever a
   wraparound happens on 32 bit the 64 bit number will be incremented by
   2 so inode numbering starts at 2 again.

   When a wraparound happens on 32 bit multiple pidfds with the same
   inode number are likely to exist. This isn't a problem since before
   pidfs pidfds used the anonymous inode meaning all pidfds had the same
   inode number. On 32 bit sserspace can thus reconstruct the 64 bit
   identifier by retrieving both the inode number and the inode
   generation number to compare, or use file handles. This gives the
   same guarantees on both 32 bit and 64 bit.

 - Implement file handle support

   This is based on custom export operation methods which allows pidfs
   to implement permission checking and opening of pidfs file handles
   cleanly without hacking around in the core file handle code too much.

 - Support bind-mounts

   Allow bind-mounting pidfds. Similar to nsfs let's allow bind-mounts
   for pidfds. This allows pidfds to be safely recovered and checked for
   process recycling.

   Instead of checking d_ops for both nsfs and pidfs we could in a
   follow-up patch add a flag argument to struct dentry_operations that
   functions similar to file_operations->fop_flags.

* tag 'vfs-6.14-rc1.pidfs' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs:
  selftests: add pidfd bind-mount tests
  pidfs: allow bind-mounts
  pidfs: lookup pid through rbtree
  selftests/pidfd: add pidfs file handle selftests
  pidfs: check for valid ioctl commands
  pidfs: implement file handle support
  exportfs: add permission method
  fhandle: pull CAP_DAC_READ_SEARCH check into may_decode_fh()
  exportfs: add open method
  fhandle: simplify error handling
  pseudofs: add support for export_ops
  pidfs: support FS_IOC_GETVERSION
  pidfs: remove 32bit inode number handling
  pidfs: rework inode number allocation

diff --combined fs/namespace.c
index 851af89e8d729f6c96679713c537ec7ed07d4bab,7baffa2ea582dacd0fa70959174fc2a47fb5de1f..64deda6f5b2cb89dda5cea28d6b187ca0c5e3952
--- 1/fs/namespace.c
--- 2/fs/namespace.c
+++ b/fs/namespace.c
@@@ -32,6 -32,7 +32,7 @@@
  #include <linux/fs_context.h>
  #include <linux/shmem_fs.h>
  #include <linux/mnt_idmapping.h>
+ #include <linux/pidfs.h>
  #include <linux/nospec.h>
  
  #include "pnode.h"
@@@ -344,7 -345,6 +345,7 @@@ static struct mount *alloc_vfsmnt(cons
                INIT_HLIST_NODE(&mnt->mnt_mp_list);
                INIT_LIST_HEAD(&mnt->mnt_umounting);
                INIT_HLIST_HEAD(&mnt->mnt_stuck_children);
 +              RB_CLEAR_NODE(&mnt->mnt_node);
                mnt->mnt.mnt_idmap = &nop_mnt_idmap;
        }
        return mnt;
@@@ -1125,7 -1125,7 +1126,7 @@@ static void mnt_add_to_ns(struct mnt_na
        struct rb_node **link = &ns->mounts.rb_node;
        struct rb_node *parent = NULL;
  
 -      WARN_ON(mnt->mnt.mnt_flags & MNT_ONRB);
 +      WARN_ON(mnt_ns_attached(mnt));
        mnt->mnt_ns = ns;
        while (*link) {
                parent = *link;
@@@ -1136,6 -1136,7 +1137,6 @@@
        }
        rb_link_node(&mnt->mnt_node, parent, link);
        rb_insert_color(&mnt->mnt_node, &ns->mounts);
 -      mnt->mnt.mnt_flags |= MNT_ONRB;
  }
  
  /*
@@@ -1305,7 -1306,7 +1306,7 @@@ static struct mount *clone_mnt(struct m
        }
  
        mnt->mnt.mnt_flags = old->mnt.mnt_flags;
 -      mnt->mnt.mnt_flags &= ~(MNT_WRITE_HOLD|MNT_MARKED|MNT_INTERNAL|MNT_ONRB);
 +      mnt->mnt.mnt_flags &= ~(MNT_WRITE_HOLD|MNT_MARKED|MNT_INTERNAL);
  
        atomic_inc(&sb->s_active);
        mnt->mnt.mnt_idmap = mnt_idmap_get(mnt_idmap(&old->mnt));
@@@ -1763,7 -1764,7 +1764,7 @@@ static void umount_tree(struct mount *m
        /* Gather the mounts to umount */
        for (p = mnt; p; p = next_mnt(p, mnt)) {
                p->mnt.mnt_flags |= MNT_UMOUNT;
 -              if (p->mnt.mnt_flags & MNT_ONRB)
 +              if (mnt_ns_attached(p))
                        move_from_ns(p, &tmp_list);
                else
                        list_move(&p->mnt_list, &tmp_list);
@@@ -1912,14 -1913,16 +1913,14 @@@ static int do_umount(struct mount *mnt
  
        event++;
        if (flags & MNT_DETACH) {
 -              if (mnt->mnt.mnt_flags & MNT_ONRB ||
 -                  !list_empty(&mnt->mnt_list))
 +              if (mnt_ns_attached(mnt) || !list_empty(&mnt->mnt_list))
                        umount_tree(mnt, UMOUNT_PROPAGATE);
                retval = 0;
        } else {
                shrink_submounts(mnt);
                retval = -EBUSY;
                if (!propagate_mount_busy(mnt, 2)) {
 -                      if (mnt->mnt.mnt_flags & MNT_ONRB ||
 -                          !list_empty(&mnt->mnt_list))
 +                      if (mnt_ns_attached(mnt) || !list_empty(&mnt->mnt_list))
                                umount_tree(mnt, UMOUNT_PROPAGATE|UMOUNT_SYNC);
                        retval = 0;
                }
@@@ -2053,15 -2056,9 +2054,15 @@@ SYSCALL_DEFINE1(oldumount, char __user 
  
  static bool is_mnt_ns_file(struct dentry *dentry)
  {
 +      struct ns_common *ns;
 +
        /* Is this a proxy for a mount namespace? */
 -      return dentry->d_op == &ns_dentry_operations &&
 -             dentry->d_fsdata == &mntns_operations;
 +      if (dentry->d_op != &ns_dentry_operations)
 +              return false;
 +
 +      ns = d_inode(dentry)->i_private;
 +
 +      return ns->ops == &mntns_operations;
  }
  
  struct ns_common *from_mnt_ns(struct mnt_namespace *mnt)
@@@ -2736,8 -2733,13 +2737,13 @@@ static struct mount *__do_loopback(stru
        if (IS_MNT_UNBINDABLE(old))
                return mnt;
  
-       if (!check_mnt(old) && old_path->dentry->d_op != &ns_dentry_operations)
-               return mnt;
+       if (!check_mnt(old)) {
+               const struct dentry_operations *d_op = old_path->dentry->d_op;
+ 
+               if (d_op != &ns_dentry_operations &&
+                   d_op != &pidfs_dentry_operations)
+                       return mnt;
+       }
  
        if (!recurse && has_locked_children(old, old_path->dentry))
                return mnt;
@@@ -3839,7 -3841,7 +3845,7 @@@ int path_mount(const char *dev_name, st
                            data_page);
  }
  
 -long do_mount(const char *dev_name, const char __user *dir_name,
 +int do_mount(const char *dev_name, const char __user *dir_name,
                const char *type_page, unsigned long flags, void *data_page)
  {
        struct path path;