]> Git Repo - linux.git/commitdiff
coccinelle: api: remove kobj_to_dev.cocci script
authorKeith Busch <[email protected]>
Mon, 21 Jun 2021 17:48:08 +0000 (10:48 -0700)
committerJulia Lawall <[email protected]>
Mon, 21 Jun 2021 18:45:49 +0000 (20:45 +0200)
Using kobj_to_dev() instead of container_of() is not universally
accepted among maintainers as an improvement. The warning leads to
repeated patch submissions that won't be accepted. Remove the script.

Cc: Christoph Hellwig <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Denis Efremov <[email protected]>
Cc: Julia Lawall <[email protected]>
Signed-off-by: Keith Busch <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
Acked-by: Jens Axboe <[email protected]>
Acked-by: Denis Efremov <[email protected]>
scripts/coccinelle/api/kobj_to_dev.cocci [deleted file]

diff --git a/scripts/coccinelle/api/kobj_to_dev.cocci b/scripts/coccinelle/api/kobj_to_dev.cocci
deleted file mode 100644 (file)
index cd5d31c..0000000
+++ /dev/null
@@ -1,45 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-///
-/// Use kobj_to_dev() instead of container_of()
-///
-// Confidence: High
-// Copyright: (C) 2020 Denis Efremov ISPRAS
-// Options: --no-includes --include-headers
-//
-// Keywords: kobj_to_dev, container_of
-//
-
-virtual context
-virtual report
-virtual org
-virtual patch
-
-
-@r depends on !patch@
-expression ptr;
-symbol kobj;
-position p;
-@@
-
-* container_of(ptr, struct device, kobj)@p
-
-
-@depends on patch@
-expression ptr;
-@@
-
-- container_of(ptr, struct device, kobj)
-+ kobj_to_dev(ptr)
-
-
-@script:python depends on report@
-p << r.p;
-@@
-
-coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()")
-
-@script:python depends on org@
-p << r.p;
-@@
-
-coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()")
This page took 0.059162 seconds and 4 git commands to generate.