]> Git Repo - linux.git/commitdiff
spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices
authorUwe Kleine-König <[email protected]>
Wed, 8 May 2024 09:56:10 +0000 (11:56 +0200)
committerMark Brown <[email protected]>
Fri, 21 Jun 2024 13:27:41 +0000 (14:27 +0100)
While in commit 2dd33f9cec90 ("spi: imx: support DMA for imx35") it was
claimed that DMA works on i.MX25, i.MX31 and i.MX35 the respective
device trees don't add DMA channels. The Reference manuals of i.MX31 and
i.MX25 also don't mention the CSPI core being DMA capable. (I didn't
check the others.)

Since commit e267a5b3ec59 ("spi: spi-imx: Use dev_err_probe for failed
DMA channel requests") this results in an error message

spi_imx 43fa4000.spi: error -ENODEV: can't get the TX DMA channel!

during boot. However that isn't fatal and the driver gets loaded just
fine, just without using DMA.

Signed-off-by: Uwe Kleine-König <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
drivers/spi/spi-imx.c

index 6f1cd3453c970d8c16a8fded86258cd5c1fa8d40..d9434fde6de6dc38f6ac5ea04c0988598f4114b4 100644 (file)
@@ -1050,7 +1050,7 @@ static struct spi_imx_devtype_data imx35_cspi_devtype_data = {
        .rx_available = mx31_rx_available,
        .reset = mx31_reset,
        .fifo_size = 8,
-       .has_dmamode = true,
+       .has_dmamode = false,
        .dynamic_burst = false,
        .has_targetmode = false,
        .devtype = IMX35_CSPI,
This page took 0.057738 seconds and 4 git commands to generate.