]> Git Repo - linux.git/commitdiff
ASoC: SOF: ops: refine parameters order in function snd_sof_dsp_update8
authorRander Wang <[email protected]>
Wed, 8 Feb 2023 10:44:04 +0000 (12:44 +0200)
committerMark Brown <[email protected]>
Wed, 8 Feb 2023 11:51:45 +0000 (11:51 +0000)
SOF driver calls snd_sof_dsp_update8 with parameters mask and value but
the snd_sof_dsp_update8 declares these two parameters in reverse order.
This causes some issues such as d0i3 register can't be set correctly
Now change function definition according to common SOF usage.

Fixes: c28a36b012f1 ("ASoC: SOF: ops: add snd_sof_dsp_updateb() helper")
Signed-off-by: Rander Wang <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
Reviewed-by: Chao Song <[email protected]>
Reviewed-by: Péter Ujfalusi <[email protected]>
Reviewed-by: Liam Girdwood <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Signed-off-by: Peter Ujfalusi <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
sound/soc/sof/ops.h

index c527522505650e5b548741d9cb1777634e830d19..3b3f3cf7af38d5816f4266640c2d0470f2a56df1 100644 (file)
@@ -357,7 +357,7 @@ static inline u64 snd_sof_dsp_read64(struct snd_sof_dev *sdev, u32 bar,
 }
 
 static inline void snd_sof_dsp_update8(struct snd_sof_dev *sdev, u32 bar,
-                                      u32 offset, u8 value, u8 mask)
+                                      u32 offset, u8 mask, u8 value)
 {
        u8 reg;
 
This page took 0.058362 seconds and 4 git commands to generate.