udf: Drop pointless check from udf_sync_fs()

The check if (bh) in udf_sync_fs() is pointless as we cannot have
sbi->s_lvid_dirty and !sbi->s_lvid_bh (as already asserted by
udf_updated_lvid()). So just drop the pointless check.

Reviewed-by: Steven J. Magnani <[email protected]>
Reported-by: Colin Ian King <[email protected]>
Signed-off-by: Jan Kara <[email protected]>

diff --git a/fs/udf/super.c b/fs/udf/super.c
index a6940d90bedde405702dd3cb47fbdc68a8dd18d1..ffd8038ff7283fc0d83211a1f5653a1589f10c4b 100644 (file)
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -2330,13 +2330,10 @@ static int udf_sync_fs(struct super_block *sb, int wait)
        mutex_lock(&sbi->s_alloc_mutex);
        if (sbi->s_lvid_dirty) {
                struct buffer_head *bh = sbi->s_lvid_bh;
+               struct logicalVolIntegrityDesc *lvid;
 
-               if (bh) {
-                       struct logicalVolIntegrityDesc *lvid;
-
-                       lvid = (struct logicalVolIntegrityDesc *)bh->b_data;
-                       udf_finalize_lvid(lvid);
-               }
+               lvid = (struct logicalVolIntegrityDesc *)bh->b_data;
+               udf_finalize_lvid(lvid);
 
                /*
                 * Blockdevice will be synced later so we don't have to submit