coccicheck: return proper error code on fail

If coccicheck fails, it should return an error code distinct from zero
to signal about an internal problem. Current code instead of exiting with
the tool's error code returns the error code of 'echo "coccicheck failed"'
which is almost always equals to zero, thus failing the original intention
of alerting about a problem. This patch fixes the code.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Denis Efremov <[email protected]>
Acked-by: Julia Lawall <[email protected]>
Signed-off-by: Masahiro Yamada <[email protected]>

diff --git a/scripts/coccicheck b/scripts/coccicheck
index 9fedca611b7f8c7e7835a4ce36f793eb7ec41754..e04d328210ac2bd55c946230f2c8f3a9fc2ba38d 100755 (executable)
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -128,9 +128,10 @@ run_cmd_parmap() {
        fi
        echo $@ >>$DEBUG_FILE
        $@ 2>>$DEBUG_FILE
-       if [[ $? -ne 0 ]]; then
+       err=$?
+       if [[ $err -ne 0 ]]; then
                echo "coccicheck failed"
-               exit $?
+               exit $err
        fi
 }