drm/edid: Add a FIXME about DispID CEA data block revision

I don't understand what the DispID CEA data block revision
means. The spec doesn't say. I guess some DispID must have
a value of >= 3 in there or else we generally wouldn't
even parse the CEA data blocks. Or does all this code
actually not do anything?

Cc: Andres Rodriguez <[email protected]>
Signed-off-by: Ville Syrjälä <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Reviewed-by: Andres Rodriguez <[email protected]>
Reviewed-by: Uma Shankar <[email protected]>

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 61f77377b49ff6e314955531a21fa2c9ef1b66ad..097e54a4379e9c627ebb7e1dd8c995a2432deaaa 100644 (file)
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -3993,6 +3993,13 @@ cea_db_tag(const u8 *db)
 static int
 cea_revision(const u8 *cea)
 {
+       /*
+        * FIXME is this correct for the DispID variant?
+        * The DispID spec doesn't really specify whether
+        * this is the revision of the CEA extension or
+        * the DispID CEA data block. And the only value
+        * given as an example is 0.
+        */
        return cea[1];
 }