rpmsg: glink: Use complete_all for open states

The open_req and open_ack completion variables are the state variables
to represet a remote channel as open. Use complete_all so there are no
races with waiters and using completion_done.

Signed-off-by: Chris Lew <[email protected]>
Signed-off-by: Arun Kumar Neelakantam <[email protected]>
Signed-off-by: Deepak Kumar Singh <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Bjorn Andersson <[email protected]>

diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 1995f5b3ea6775e22f85dc97461a107fc5b4c561..d5114abcde197593a5f9cf4f994d6a4fa62d4c9a 100644 (file)
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -970,7 +970,7 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid)
                return -EINVAL;
        }
 
-       complete(&channel->open_ack);
+       complete_all(&channel->open_ack);
 
        return 0;
 }
@@ -1178,7 +1178,7 @@ static int qcom_glink_announce_create(struct rpmsg_device *rpdev)
        __be32 *val = defaults;
        int size;
 
-       if (glink->intentless)
+       if (glink->intentless || !completion_done(&channel->open_ack))
                return 0;
 
        prop = of_find_property(np, "qcom,intents", NULL);
@@ -1413,7 +1413,7 @@ static int qcom_glink_rx_open(struct qcom_glink *glink, unsigned int rcid,
        channel->rcid = ret;
        spin_unlock_irqrestore(&glink->idr_lock, flags);
 
-       complete(&channel->open_req);
+       complete_all(&channel->open_req);
 
        if (create_device) {
                rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL);