]> Git Repo - linux.git/commitdiff
cfg80211: fix memory leak of wiphy device name
authorEric Biggers <[email protected]>
Mon, 10 Jun 2019 20:02:19 +0000 (13:02 -0700)
committerJohannes Berg <[email protected]>
Fri, 14 Jun 2019 13:46:33 +0000 (15:46 +0200)
In wiphy_new_nm(), if an error occurs after dev_set_name() and
device_initialize() have already been called, it's necessary to call
put_device() (via wiphy_free()) to avoid a memory leak.

Reported-by: [email protected]
Fixes: 1f87f7d3a3b4 ("cfg80211: add rfkill support")
Cc: [email protected]
Signed-off-by: Eric Biggers <[email protected]>
Signed-off-by: Johannes Berg <[email protected]>
net/wireless/core.c

index 4e83892f1ac2584e452c9da9d6cc234a489e4414..c58acca093012efe6b55c1f73224eded9fdc5caf 100644 (file)
@@ -513,7 +513,7 @@ use_default_name:
                                   &rdev->rfkill_ops, rdev);
 
        if (!rdev->rfkill) {
-               kfree(rdev);
+               wiphy_free(&rdev->wiphy);
                return NULL;
        }
 
This page took 0.061005 seconds and 4 git commands to generate.