vDPA: dont change vq irq after DRIVER_OK

IRQ of a vq is not expected to be changed in a DRIVER_OK ~ !DRIVER_OK
period for irq offloading purposes. Place this comment at the side of
bus ops get_vq_irq than in set_status in vhost_vdpa.

Signed-off-by: Zhu Lingshan <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Michael S. Tsirkin <[email protected]>

diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index 7441b9803eae67ac73a3987ae80e080a9ac54a2d..f8f8c9cf05b01058d6b161b6ec81cbe23beee09e 100644 (file)
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -172,7 +172,6 @@ static long vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user *statusp)
 
        ops->set_status(vdpa, status);
 
-       /* vq irq is not expected to be changed once DRIVER_OK is set */
        if ((status & VIRTIO_CONFIG_S_DRIVER_OK) && !(status_old & VIRTIO_CONFIG_S_DRIVER_OK))
                for (i = 0; i < nvqs; i++)
                        vhost_vdpa_setup_vq_irq(v, i);

diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
index 5c530a64aa066ca84cc6388a917ef2f38c809e0f..565298cb45d20f2ff9b7de35735dc3b8ae91369c 100644 (file)
--- a/include/linux/vdpa.h
+++ b/include/linux/vdpa.h
@@ -186,6 +186,7 @@ struct vdpa_config_ops {
        u64 (*get_vq_state)(struct vdpa_device *vdev, u16 idx);
        struct vdpa_notification_area
        (*get_vq_notification)(struct vdpa_device *vdev, u16 idx);
+       /* vq irq is not expected to be changed once DRIVER_OK is set */
        int (*get_vq_irq)(struct vdpa_device *vdv, u16 idx);
 
        /* Device ops */