]> Git Repo - linux.git/commitdiff
soundwire: intel: fix implicit header use of module.h/export.h
authorPaul Gortmaker <[email protected]>
Sat, 13 Apr 2019 15:12:52 +0000 (11:12 -0400)
committerVinod Koul <[email protected]>
Sun, 14 Apr 2019 10:22:50 +0000 (15:52 +0530)
These two files are implicitly relying on an instance of including
module.h from <linux/acpi.h>.

Ideally, header files under include/linux shouldn't be adding
includes of other headers, in anticipation of their consumers,
but just the headers needed for the header itself to pass
parsing with CPP.

The module.h is particularly bad in this sense, as it itself does
include a whole bunch of other headers, due to the complexity of
module support.

Here, we make those includes explicit, in order to allow a future
removal of module.h from linux/acpi.h without causing build breakage.

Cc: Vinod Koul <[email protected]>
Cc: Sanyog Kale <[email protected]>
Cc: Pierre-Louis Bossart <[email protected]>
Signed-off-by: Paul Gortmaker <[email protected]>
Signed-off-by: Vinod Koul <[email protected]>
drivers/soundwire/intel.c
drivers/soundwire/intel_init.c

index 8669b314c4760fdec1dad3165110df9f096e5cef..70ca27ccad8553cb71738496133f76f2716614bc 100644 (file)
@@ -7,6 +7,7 @@
 
 #include <linux/acpi.h>
 #include <linux/delay.h>
+#include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include <sound/pcm_params.h>
index 5c8a20d998786459afa4f4c7d8531c20e8d92631..e0f2903101c7461389bc58e96336eecf2e8cd277 100644 (file)
@@ -8,6 +8,8 @@
  */
 
 #include <linux/acpi.h>
+#include <linux/export.h>
+#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/soundwire/sdw_intel.h>
 #include "intel.h"
This page took 0.053177 seconds and 4 git commands to generate.