]> Git Repo - linux.git/commitdiff
jbd2: Fix comment describing journal_init_common()
authorDaniel Martín Gómez <[email protected]>
Thu, 7 Nov 2024 14:45:38 +0000 (15:45 +0100)
committerTheodore Ts'o <[email protected]>
Wed, 13 Nov 2024 17:56:48 +0000 (12:56 -0500)
The code indicates that journal_init_common() fills the journal_t object
it returns while the comment incorrectly states that only a few fields are
initialised.  Also, the comment claims that journal structures could be
created from scratch which isn't possible as journal_init_common() calls
journal_load_superblock() which loads and checks journal superblock from
disk.

Signed-off-by: Daniel Martín Gómez <[email protected]>
Reviewed-by: Jan Kara <[email protected]>
Reviewed-by: Zhang Yi <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Theodore Ts'o <[email protected]>
fs/jbd2/journal.c

index 29d30eddf727180b227c6e0cd1e561453cbb9da0..7e49d912b091728ae0e90fb820ee20c755eb465e 100644 (file)
@@ -1512,9 +1512,10 @@ static int journal_load_superblock(journal_t *journal)
  * destroy journal_t structures, and to initialise and read existing
  * journal blocks from disk.  */
 
-/* First: create and setup a journal_t object in memory.  We initialise
- * very few fields yet: that has to wait until we have created the
- * journal structures from from scratch, or loaded them from disk. */
+/* The journal_init_common() function creates and fills a journal_t object
+ * in memory. It calls journal_load_superblock() to load the on-disk journal
+ * superblock and initialize the journal_t object.
+ */
 
 static journal_t *journal_init_common(struct block_device *bdev,
                        struct block_device *fs_dev,
This page took 0.059802 seconds and 4 git commands to generate.