]> Git Repo - linux.git/commitdiff
drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP
authorThomas Zimmermann <[email protected]>
Thu, 3 Feb 2022 09:39:22 +0000 (10:39 +0100)
committerDave Airlie <[email protected]>
Sat, 12 Mar 2022 07:41:30 +0000 (17:41 +1000)
As reported in [1], DRM_PANEL_EDP depends on DRM_DP_HELPER. Select
the option to fix the build failure. The error message is shown
below.

  arm-linux-gnueabihf-ld: drivers/gpu/drm/panel/panel-edp.o: in function
    `panel_edp_probe': panel-edp.c:(.text+0xb74): undefined reference to
    `drm_panel_dp_aux_backlight'
  make[1]: *** [/builds/linux/Makefile:1222: vmlinux] Error 1

The issue has been reported before, when DisplayPort helpers were
hidden behind the option CONFIG_DRM_KMS_HELPER. [2]

v2:
* fix and expand commit description (Arnd)

Signed-off-by: Thomas Zimmermann <[email protected]>
Fixes: 9d6366e743f3 ("drm: fb_helper: improve CONFIG_FB dependency")
Reported-by: Naresh Kamboju <[email protected]>
Reported-by: Linux Kernel Functional Testing <[email protected]>
Reviewed-by: Lyude Paul <[email protected]>
Acked-by: Sam Ravnborg <[email protected]>
Link: https://lore.kernel.org/dri-devel/CA+G9fYvN0NyaVkRQmA1O6rX7H8PPaZrUAD7=RDy33QY9rUU-9g@mail.gmail.com/
Link: https://lore.kernel.org/all/[email protected]/
Cc: Thomas Zimmermann <[email protected]>
Cc: Lyude Paul <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Maarten Lankhorst <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: [email protected]
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Signed-off-by: Dave Airlie <[email protected]>
drivers/gpu/drm/panel/Kconfig

index 434c2861bb40c0a4be85fece9abb340c2483ca50..0aec5a10b064b4b93940615160b6a7fe727576a9 100644 (file)
@@ -106,6 +106,7 @@ config DRM_PANEL_EDP
        depends on PM
        select VIDEOMODE_HELPERS
        select DRM_DP_AUX_BUS
+       select DRM_DP_HELPER
        help
          DRM panel driver for dumb eDP panels that need at most a regulator and
          a GPIO to be powered up. Optionally a backlight can be attached so
This page took 0.063144 seconds and 4 git commands to generate.