batman-adv: fix tt_local_reset_flags() function

Currently the counter of tt_local_entry structures (tt_local_num) is incremented
each time the tt_local_reset_flags() is invoked causing the node to send wrong
TT_REPONSE packets containing a copy of non-initialised memory thus corrupting
other nodes global translation table and making higher level communication
impossible.

Reported-by: Junkeun Song <[email protected]>
Signed-off-by: Antonio Quartulli <[email protected]>
Acked-by: Junkeun Song <[email protected]>
Signed-off-by: Marek Lindner <[email protected]>

diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index fb6931d00cd7f3ae73f46a354f62ce7e82613360..f599db9dbec1bd1e9631e2485faef732f3c1cfc8 100644 (file)
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -1668,6 +1668,8 @@ static void tt_local_reset_flags(struct bat_priv *bat_priv, uint16_t flags)
                rcu_read_lock();
                hlist_for_each_entry_rcu(tt_local_entry, node,
                                         head, hash_entry) {
+                       if (!(tt_local_entry->flags & flags))
+                               continue;
                        tt_local_entry->flags &= ~flags;
                        atomic_inc(&bat_priv->num_local_tt);
                }