]> Git Repo - linux.git/commitdiff
selftests/bpf: Set gopt opt_class to 0 if get tunnel opt failed
authorHangbin Liu <[email protected]>
Tue, 9 Mar 2021 03:22:14 +0000 (11:22 +0800)
committerDaniel Borkmann <[email protected]>
Mon, 15 Mar 2021 16:28:58 +0000 (17:28 +0100)
When fixing the bpf test_tunnel.sh geneve failure. I only fixed the IPv4
part but forgot the IPv6 issue. Similar with the IPv4 fixes 557c223b643a
("selftests/bpf: No need to drop the packet when there is no geneve opt"),
when there is no tunnel option and bpf_skb_get_tunnel_opt() returns error,
there is no need to drop the packets and break all geneve rx traffic.
Just set opt_class to 0 and keep returning TC_ACT_OK at the end.

Fixes: 557c223b643a ("selftests/bpf: No need to drop the packet when there is no geneve opt")
Fixes: 933a741e3b82 ("selftests/bpf: bpf tunnel test.")
Signed-off-by: Hangbin Liu <[email protected]>
Signed-off-by: Daniel Borkmann <[email protected]>
Acked-by: William Tu <[email protected]>
Link: https://lore.kernel.org/bpf/[email protected]
tools/testing/selftests/bpf/progs/test_tunnel_kern.c

index 9afe947cfae95302937b36264791475acce22fc3..ba6eadfec56531134e532d8bfdb516cb12960198 100644 (file)
@@ -508,10 +508,8 @@ int _ip6geneve_get_tunnel(struct __sk_buff *skb)
        }
 
        ret = bpf_skb_get_tunnel_opt(skb, &gopt, sizeof(gopt));
-       if (ret < 0) {
-               ERROR(ret);
-               return TC_ACT_SHOT;
-       }
+       if (ret < 0)
+               gopt.opt_class = 0;
 
        bpf_trace_printk(fmt, sizeof(fmt),
                        key.tunnel_id, key.remote_ipv4, gopt.opt_class);
This page took 0.083155 seconds and 4 git commands to generate.