]> Git Repo - linux.git/commitdiff
hpwdt: Fix kdump issue in hpwdt
authorToshi Kani <[email protected]>
Mon, 27 Aug 2012 18:52:24 +0000 (12:52 -0600)
committerWim Van Sebroeck <[email protected]>
Mon, 10 Sep 2012 15:28:08 +0000 (17:28 +0200)
kdump can be interrupted by watchdog timer when the timer is left
activated on the crash kernel. Changed the hpwdt driver to disable
watchdog timer at boot-time. This assures that watchdog timer is
disabled until /dev/watchdog is opened, and prevents watchdog timer
to be left running on the crash kernel.

Signed-off-by: Toshi Kani <[email protected]>
Tested-by: Lisa Mitchell <[email protected]>
Signed-off-by: Thomas Mingarelli <[email protected]>
Signed-off-by: Wim Van Sebroeck <[email protected]>
Cc: stable <[email protected]>
drivers/watchdog/hpwdt.c

index 1eff743ec4970071f8451704fb51d4b06de70950..ae60406ea8a1878cefd03d29868eda31b955578f 100644 (file)
@@ -814,6 +814,9 @@ static int __devinit hpwdt_init_one(struct pci_dev *dev,
        hpwdt_timer_reg = pci_mem_addr + 0x70;
        hpwdt_timer_con = pci_mem_addr + 0x72;
 
+       /* Make sure that timer is disabled until /dev/watchdog is opened */
+       hpwdt_stop();
+
        /* Make sure that we have a valid soft_margin */
        if (hpwdt_change_timer(soft_margin))
                hpwdt_change_timer(DEFAULT_MARGIN);
This page took 0.066188 seconds and 4 git commands to generate.