wifi: cfg80211: correct comment about MLD ID

The comment was referencing the wrong section of the documentation and
was also subtly wrong as it assumed the rules that apply when sending
probe requests directly to a nontransmitted AP. However, in that case
the response comes from the transmitting AP and the AP MLD ID will be
included.

Fixes: 2481b5da9c6b ("wifi: cfg80211: handle BSS data contained in ML probe responses")
Signed-off-by: Benjamin Berg <[email protected]>
Signed-off-by: Miri Korenblit <[email protected]>
Link: https://msgid.link/20240102213313.0917ab4b5d7f.I76aff0e261a5de44ffb467e591a46597a30d7c0a@changeid
Signed-off-by: Johannes Berg <[email protected]>

diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index b2ed45ea35d38e05f97fb7656e4c01ae80a9329f..4c01127fccc4d8fd90f3005f3970f00551b6aa31 100644 (file)
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -2676,8 +2676,11 @@ static void cfg80211_parse_ml_sta_data(struct wiphy *wiphy,
        /* MLD capabilities and operations */
        pos += 2;
 
-       /* Not included when the (nontransmitted) AP is responding itself,
-        * but defined to zero then (Draft P802.11be_D3.0, 9.4.2.170.2)
+       /*
+        * The MLD ID of the reporting AP is always zero. It is set if the AP
+        * is part of an MBSSID set and will be non-zero for ML Elements
+        * relating to a nontransmitted BSS (matching the Multi-BSSID Index,
+        * Draft P802.11be_D3.2, 35.3.4.2)
         */
        if (u16_get_bits(control, IEEE80211_MLC_BASIC_PRES_MLD_ID)) {
                mld_id = *pos;