]> Git Repo - linux.git/commitdiff
x86/vdso: Remove a stale/misleading comment from the linker script
authorSean Christopherson <[email protected]>
Tue, 4 Dec 2018 21:25:58 +0000 (13:25 -0800)
committerIngo Molnar <[email protected]>
Wed, 5 Dec 2018 07:58:12 +0000 (08:58 +0100)
Once upon a time, vdso2c aggressively stripped data from the vDSO
image when generating the final userspace image.  This included
stripping the .altinstructions and .altinstr_replacement sections.
Eventually, the stripping process reverted to "objdump -S" and no
longer removed the aforementioned sections, but the comment remained.

Keeping the .alt* sections at the end of the PT_LOAD segment is no
longer necessary, but there's no harm in doing so and it's a helpful
reminder that they don't need to be included in the final vDSO image,
i.e. someone may want to take another stab at zapping/stripping the
unneeded sections.

Signed-off-by: Sean Christopherson <[email protected]>
Acked-by: Andy Lutomirski <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: Brian Gerst <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: Denys Vlasenko <[email protected]>
Cc: H. Peter Anvin <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Rik van Riel <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Fixes: da861e18eccc ("x86, vdso: Get rid of the fake section mechanism")
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
arch/x86/entry/vdso/vdso-layout.lds.S

index 0cedc905c8d6704b967daba8ad0f438fa9fe8c35..93c6dc7812d04602c9c00f3ca3f60ea7490c757e 100644 (file)
@@ -65,11 +65,6 @@ SECTIONS
 
        .text           : { *(.text*) }                 :text   =0x90909090,
 
-       /*
-        * At the end so that eu-elflint stays happy when vdso2c strips
-        * these.  A better implementation would avoid allocating space
-        * for these.
-        */
        .altinstructions        : { *(.altinstructions) }       :text
        .altinstr_replacement   : { *(.altinstr_replacement) }  :text
 
This page took 0.061793 seconds and 4 git commands to generate.