]> Git Repo - linux.git/commitdiff
i3c/master/mipi-i3c-hci: Fix position of __maybe_unused in i3c_hci_of_match
authorNathan Chancellor <[email protected]>
Tue, 22 Dec 2020 02:59:31 +0000 (19:59 -0700)
committerAlexandre Belloni <[email protected]>
Thu, 31 Dec 2020 17:41:37 +0000 (18:41 +0100)
Clang warns:

 ../drivers/i3c/master/mipi-i3c-hci/core.c:780:21: warning: attribute
 declaration must precede definition [-Wignored-attributes]
 static const struct __maybe_unused of_device_id i3c_hci_of_match[] = {
                     ^
 ../include/linux/compiler_attributes.h:267:56: note: expanded from macro
 '__maybe_unused'
 #define __maybe_unused                  __attribute__((__unused__))
                                                        ^
 ../include/linux/mod_devicetable.h:262:8: note: previous definition is
 here
 struct of_device_id {
        ^
1 warning generated.

'struct of_device_id' should not be split, as it is a type. Move the
__maybe_unused attribute after the static and const qualifiers so that
there are no warnings about this variable, period.

Fixes: 95393f3e07ab ("i3c/master/mipi-i3c-hci: quiet maybe-unused variable warning")
Link: https://github.com/ClangBuiltLinux/linux/issues/1221
Signed-off-by: Nathan Chancellor <[email protected]>
Acked-by: Nicolas Pitre <[email protected]>
Signed-off-by: Alexandre Belloni <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
drivers/i3c/master/mipi-i3c-hci/core.c

index 500abd27fb225e5e9e794b06277e1eb1aa998dae..1b73647cc3b1a658ab94804bdbf6b35aed310a18 100644 (file)
@@ -777,7 +777,7 @@ static int i3c_hci_remove(struct platform_device *pdev)
        return 0;
 }
 
-static const struct __maybe_unused of_device_id i3c_hci_of_match[] = {
+static const __maybe_unused struct of_device_id i3c_hci_of_match[] = {
        { .compatible = "mipi-i3c-hci", },
        {},
 };
This page took 0.060525 seconds and 4 git commands to generate.