]> Git Repo - linux.git/commitdiff
drm/i915: Reduce severity for fixing up mistaken VBT tc->legacy_port
authorChris Wilson <[email protected]>
Fri, 30 Oct 2020 15:32:09 +0000 (15:32 +0000)
committerChris Wilson <[email protected]>
Fri, 30 Oct 2020 19:10:28 +0000 (19:10 +0000)
If the VBT assigned tc->legacy_port mismatches the live_status indicator
for the connector, we ignore the VBT directive and switch over to the HW
setting. This is not a driver error, unless we happen to misparse the
VBT or the live_status registers. However, for the system in CI where
the error is only reported on 1 port out of 4, the evidence indicates
the VBT is wrong. Stop flaging this as an error since the cause is
beyond our control, fixup the mistake and continue on.

Signed-off-by: Chris Wilson <[email protected]>
Cc: Imre Deak <[email protected]>
Reviewed-by: Imre Deak <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
drivers/gpu/drm/i915/display/intel_tc.c

index 1cb548d757e162797a030d0f4b34b4ff973121f2..4346bc1a747a2ee809f846eb7b393c75b1e1b60f 100644 (file)
@@ -228,9 +228,9 @@ static void tc_port_fixup_legacy_flag(struct intel_digital_port *dig_port,
                return;
 
        /* If live status mismatches the VBT flag, trust the live status. */
-       drm_err(&i915->drm,
-               "Port %s: live status %08x mismatches the legacy port flag, fix flag\n",
-               dig_port->tc_port_name, live_status_mask);
+       drm_dbg_kms(&i915->drm,
+                   "Port %s: live status %08x mismatches the legacy port flag %08x, fixing flag\n",
+                   dig_port->tc_port_name, live_status_mask, valid_hpd_mask);
 
        dig_port->tc_legacy_port = !dig_port->tc_legacy_port;
 }
This page took 0.058277 seconds and 4 git commands to generate.