]> Git Repo - linux.git/commitdiff
perf: starfive: fix 64-bit only COMPILE_TEST condition
authorConor Dooley <[email protected]>
Mon, 18 Mar 2024 15:35:04 +0000 (15:35 +0000)
committerCatalin Marinas <[email protected]>
Tue, 19 Mar 2024 19:01:39 +0000 (19:01 +0000)
ARCH_STARFIVE is not restricted to 64-bit platforms, so while Will's
addition of a 64-bit only condition satisfied the build robots doing
COMPILE_TEST builds, Palmer ran into the same problems with writeq()
being undefined during regular rv32 builds.

Promote the dependency on 64-bit to its own `depends on` so that the
driver can never be included in 32-bit builds.

Reported-by: Palmer Dabbelt <[email protected]>
Fixes: c2b24812f7bc ("perf: starfive: Add StarLink PMU support")
Fixes: f0dbc6d0de38 ("perf: starfive: Only allow COMPILE_TEST for 64-bit architectures")
Signed-off-by: Conor Dooley <[email protected]>
Acked-by: Will Deacon <[email protected]>
Reviewed-by: Palmer Dabbelt <[email protected]>
Acked-by: Palmer Dabbelt <[email protected]>
Acked-by: Ji Sheng Teoh <[email protected]>
Acked-by: Emil Renner Berthing <[email protected]>
Link: https://lore.kernel.org/r/20240318-emphatic-rally-f177a4fe1bdc@spud
Signed-off-by: Catalin Marinas <[email protected]>
drivers/perf/Kconfig

index 004d86230aa6308a07823f267cfebce6e4ac39f5..54ff5cc17ccdb459bfa430331060abfd68ea6da2 100644 (file)
@@ -87,7 +87,8 @@ config RISCV_PMU_SBI
          filtering, counter configuration.
 
 config STARFIVE_STARLINK_PMU
-       depends on ARCH_STARFIVE || (COMPILE_TEST && 64BIT)
+       depends on ARCH_STARFIVE || COMPILE_TEST
+       depends on 64BIT
        bool "StarFive StarLink PMU"
        help
           Provide support for StarLink Performance Monitor Unit.
This page took 0.086602 seconds and 4 git commands to generate.