drm/qxl: prevent memory leak

The allocated memory for qdev->dumb_heads should be released
in qxl_destroy_monitors_object before qxl suspend.
otherwise,qxl_create_monitors_object will be called to
reallocate memory for qdev->dumb_heads after qxl resume,
it will cause memory leak.

Signed-off-by: Zongmin Zhou <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Dave Airlie <[email protected]>
Signed-off-by: Maxime Ripard <[email protected]>

diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 6492a70e3c396a5b18590a5bf342c18b31560646..404b0483bb7cb91d98703f1cf13a404cb642d1d6 100644 (file)
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -1229,6 +1229,9 @@ int qxl_destroy_monitors_object(struct qxl_device *qdev)
        if (!qdev->monitors_config_bo)
                return 0;
 
+       kfree(qdev->dumb_heads);
+       qdev->dumb_heads = NULL;
+
        qdev->monitors_config = NULL;
        qdev->ram_header->monitors_config = 0;