bnxt_en: Make PTP TX timestamp HWRM query silent

In a busy network, especially with flow control enabled, we may
experience timestamp query failures fairly regularly. After a while,
dmesg may be flooded with timestamp query failure error messages.

Silence the error message from the low level hwrm function that
sends the firmware message.  Change netdev_err() to netdev_WARN_ONCE()
if this FW call ever fails.

Signed-off-by: Pavan Chebbi <[email protected]>
Signed-off-by: Michael Chan <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
index 3d1c36d384c2d7ce54770149e63da2369f061aae..adad188e38b8256ef5a1e051310abae2d5bd9b34 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
@@ -129,7 +129,7 @@ static int bnxt_hwrm_port_ts_query(struct bnxt *bp, u32 flags, u64 *ts)
        }
        resp = hwrm_req_hold(bp, req);
 
-       rc = hwrm_req_send(bp, req);
+       rc = hwrm_req_send_silent(bp, req);
        if (!rc)
                *ts = le64_to_cpu(resp->ptp_msg_ts);
        hwrm_req_drop(bp, req);
@@ -684,8 +684,8 @@ static void bnxt_stamp_tx_skb(struct bnxt *bp, struct sk_buff *skb)
                timestamp.hwtstamp = ns_to_ktime(ns);
                skb_tstamp_tx(ptp->tx_skb, &timestamp);
        } else {
-               netdev_err(bp->dev, "TS query for TX timer failed rc = %x\n",
-                          rc);
+               netdev_WARN_ONCE(bp->dev,
+                                "TS query for TX timer failed rc = %x\n", rc);
        }
 
        dev_kfree_skb_any(ptp->tx_skb);