]> Git Repo - linux.git/commitdiff
drm/i915: Set correct domains values at _i915_vma_move_to_active
authorNirmoy Das <[email protected]>
Wed, 7 Sep 2022 17:26:41 +0000 (19:26 +0200)
committerMatthew Auld <[email protected]>
Thu, 8 Sep 2022 10:06:35 +0000 (11:06 +0100)
Fix regression introduced by commit:
"drm/i915: Individualize fences before adding to dma_resv obj"
which sets obj->read_domains to 0 for both read and write paths.
Also set obj->write_domain to 0 on read path which was removed by
the commit.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/6639
Fixes: 420a07b841d0 ("drm/i915: Individualize fences before adding to dma_resv obj")
Signed-off-by: Nirmoy Das <[email protected]>
Cc: <[email protected]> # v5.16+
Cc: Matthew Auld <[email protected]>
Cc: Andrzej Hajda <[email protected]>
Reviewed-by: Andrzej Hajda <[email protected]>
Signed-off-by: Matthew Auld <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
drivers/gpu/drm/i915/i915_vma.c

index e300f8070c1d9f20127572c4d80f277a81e85d48..f17c09ead7d778752c332c267c9da41b07d8dc22 100644 (file)
@@ -1882,12 +1882,13 @@ int _i915_vma_move_to_active(struct i915_vma *vma,
                enum dma_resv_usage usage;
                int idx;
 
-               obj->read_domains = 0;
                if (flags & EXEC_OBJECT_WRITE) {
                        usage = DMA_RESV_USAGE_WRITE;
                        obj->write_domain = I915_GEM_DOMAIN_RENDER;
+                       obj->read_domains = 0;
                } else {
                        usage = DMA_RESV_USAGE_READ;
+                       obj->write_domain = 0;
                }
 
                dma_fence_array_for_each(curr, idx, fence)
This page took 0.061918 seconds and 4 git commands to generate.