]> Git Repo - linux.git/commitdiff
SUNRPC: Remove unreachable error condition in rpcb_getport_async()
authorXiyu Yang <[email protected]>
Mon, 25 May 2020 14:17:02 +0000 (22:17 +0800)
committerJ. Bruce Fields <[email protected]>
Thu, 28 May 2020 22:15:00 +0000 (18:15 -0400)
rpcb_getport_async() invokes rpcb_call_async(), which return the value
of rpc_run_task() to "child". Since rpc_run_task() is impossible to
return an ERR pointer, there is no need to add the IS_ERR() condition on
"child" here. So we need to remove it.

Signed-off-by: Xiyu Yang <[email protected]>
Signed-off-by: Xin Tan <[email protected]>
Signed-off-by: J. Bruce Fields <[email protected]>
net/sunrpc/rpcb_clnt.c

index 4a020b6888608b0c41864d9ac06477bcffe5525c..c27123e6ba80c1f166c1212aedf6f6385c6b1950 100644 (file)
@@ -795,12 +795,6 @@ void rpcb_getport_async(struct rpc_task *task)
 
        child = rpcb_call_async(rpcb_clnt, map, proc);
        rpc_release_client(rpcb_clnt);
-       if (IS_ERR(child)) {
-               /* rpcb_map_release() has freed the arguments */
-               dprintk("RPC: %5u %s: rpc_run_task failed\n",
-                       task->tk_pid, __func__);
-               return;
-       }
 
        xprt->stat.bind_count++;
        rpc_put_task(child);
This page took 0.042977 seconds and 4 git commands to generate.