2 * coretemp.c - Linux kernel module for hardware monitoring
6 * Inspired from many hwmon drivers
8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; version 2 of the License.
12 * This program is distributed in the hope that it will be useful,
13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 * GNU General Public License for more details.
17 * You should have received a copy of the GNU General Public License
18 * along with this program; if not, write to the Free Software
19 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
23 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
25 #include <linux/module.h>
26 #include <linux/init.h>
27 #include <linux/slab.h>
28 #include <linux/jiffies.h>
29 #include <linux/hwmon.h>
30 #include <linux/sysfs.h>
31 #include <linux/hwmon-sysfs.h>
32 #include <linux/err.h>
33 #include <linux/mutex.h>
34 #include <linux/list.h>
35 #include <linux/platform_device.h>
36 #include <linux/cpu.h>
37 #include <linux/smp.h>
38 #include <linux/moduleparam.h>
39 #include <linux/pci.h>
41 #include <asm/processor.h>
42 #include <asm/cpu_device_id.h>
44 #define DRVNAME "coretemp"
47 * force_tjmax only matters when TjMax can't be read from the CPU itself.
48 * When set, it replaces the driver's suboptimal heuristic.
50 static int force_tjmax;
51 module_param_named(tjmax, force_tjmax, int, 0444);
52 MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
54 #define BASE_SYSFS_ATTR_NO 2 /* Sysfs Base attr no for coretemp */
55 #define NUM_REAL_CORES 32 /* Number of Real cores per cpu */
56 #define CORETEMP_NAME_LENGTH 19 /* String Length of attrs */
57 #define MAX_CORE_ATTRS 4 /* Maximum no of basic attrs */
58 #define TOTAL_ATTRS (MAX_CORE_ATTRS + 1)
59 #define MAX_CORE_DATA (NUM_REAL_CORES + BASE_SYSFS_ATTR_NO)
61 #define TO_PHYS_ID(cpu) (cpu_data(cpu).phys_proc_id)
62 #define TO_CORE_ID(cpu) (cpu_data(cpu).cpu_core_id)
63 #define TO_ATTR_NO(cpu) (TO_CORE_ID(cpu) + BASE_SYSFS_ATTR_NO)
66 #define for_each_sibling(i, cpu) for_each_cpu(i, cpu_sibling_mask(cpu))
68 #define for_each_sibling(i, cpu) for (i = 0; false; )
72 * Per-Core Temperature Data
73 * @last_updated: The time when the current temperature value was updated
74 * earlier (in jiffies).
75 * @cpu_core_id: The CPU Core from which temperature values should be read
76 * This value is passed as "id" field to rdmsr/wrmsr functions.
77 * @status_reg: One of IA32_THERM_STATUS or IA32_PACKAGE_THERM_STATUS,
78 * from where the temperature values should be read.
79 * @attr_size: Total number of pre-core attrs displayed in the sysfs.
80 * @is_pkg_data: If this is 1, the temp_data holds pkgtemp data.
81 * Otherwise, temp_data holds coretemp data.
82 * @valid: If this is 1, the current temperature is valid.
88 unsigned long last_updated;
95 struct sensor_device_attribute sd_attrs[TOTAL_ATTRS];
96 char attr_name[TOTAL_ATTRS][CORETEMP_NAME_LENGTH];
97 struct mutex update_lock;
100 /* Platform Data per Physical CPU */
101 struct platform_data {
102 struct device *hwmon_dev;
104 struct temp_data *core_data[MAX_CORE_DATA];
105 struct device_attribute name_attr;
109 struct list_head list;
110 struct platform_device *pdev;
114 static LIST_HEAD(pdev_list);
115 static DEFINE_MUTEX(pdev_list_mutex);
117 static ssize_t show_name(struct device *dev,
118 struct device_attribute *devattr, char *buf)
120 return sprintf(buf, "%s\n", DRVNAME);
123 static ssize_t show_label(struct device *dev,
124 struct device_attribute *devattr, char *buf)
126 struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
127 struct platform_data *pdata = dev_get_drvdata(dev);
128 struct temp_data *tdata = pdata->core_data[attr->index];
130 if (tdata->is_pkg_data)
131 return sprintf(buf, "Physical id %u\n", pdata->phys_proc_id);
133 return sprintf(buf, "Core %u\n", tdata->cpu_core_id);
136 static ssize_t show_crit_alarm(struct device *dev,
137 struct device_attribute *devattr, char *buf)
140 struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
141 struct platform_data *pdata = dev_get_drvdata(dev);
142 struct temp_data *tdata = pdata->core_data[attr->index];
144 rdmsr_on_cpu(tdata->cpu, tdata->status_reg, &eax, &edx);
146 return sprintf(buf, "%d\n", (eax >> 5) & 1);
149 static ssize_t show_tjmax(struct device *dev,
150 struct device_attribute *devattr, char *buf)
152 struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
153 struct platform_data *pdata = dev_get_drvdata(dev);
155 return sprintf(buf, "%d\n", pdata->core_data[attr->index]->tjmax);
158 static ssize_t show_ttarget(struct device *dev,
159 struct device_attribute *devattr, char *buf)
161 struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
162 struct platform_data *pdata = dev_get_drvdata(dev);
164 return sprintf(buf, "%d\n", pdata->core_data[attr->index]->ttarget);
167 static ssize_t show_temp(struct device *dev,
168 struct device_attribute *devattr, char *buf)
171 struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
172 struct platform_data *pdata = dev_get_drvdata(dev);
173 struct temp_data *tdata = pdata->core_data[attr->index];
175 mutex_lock(&tdata->update_lock);
177 /* Check whether the time interval has elapsed */
178 if (!tdata->valid || time_after(jiffies, tdata->last_updated + HZ)) {
179 rdmsr_on_cpu(tdata->cpu, tdata->status_reg, &eax, &edx);
181 * Ignore the valid bit. In all observed cases the register
182 * value is either low or zero if the valid bit is 0.
183 * Return it instead of reporting an error which doesn't
184 * really help at all.
186 tdata->temp = tdata->tjmax - ((eax >> 16) & 0x7f) * 1000;
188 tdata->last_updated = jiffies;
191 mutex_unlock(&tdata->update_lock);
192 return sprintf(buf, "%d\n", tdata->temp);
200 static const struct tjmax_pci tjmax_pci_table[] = {
201 { 0x0708, 110000 }, /* CE41x0 (Sodaville ) */
202 { 0x0c72, 102000 }, /* Atom S1240 (Centerton) */
203 { 0x0c73, 95000 }, /* Atom S1220 (Centerton) */
204 { 0x0c75, 95000 }, /* Atom S1260 (Centerton) */
212 static const struct tjmax tjmax_table[] = {
213 { "CPU 230", 100000 }, /* Model 0x1c, stepping 2 */
214 { "CPU 330", 125000 }, /* Model 0x1c, stepping 2 */
225 static const struct tjmax_model tjmax_model_table[] = {
226 { 0x1c, 10, 100000 }, /* D4xx, K4xx, N4xx, D5xx, K5xx, N5xx */
227 { 0x1c, ANY, 90000 }, /* Z5xx, N2xx, possibly others
228 * Note: Also matches 230 and 330,
229 * which are covered by tjmax_table
231 { 0x26, ANY, 90000 }, /* Atom Tunnel Creek (Exx), Lincroft (Z6xx)
232 * Note: TjMax for E6xxT is 110C, but CPU type
233 * is undetectable by software
235 { 0x27, ANY, 90000 }, /* Atom Medfield (Z2460) */
236 { 0x35, ANY, 90000 }, /* Atom Clover Trail/Cloverview (Z27x0) */
237 { 0x36, ANY, 100000 }, /* Atom Cedar Trail/Cedarview (N2xxx, D2xxx)
238 * Also matches S12x0 (stepping 9), covered by
243 static int adjust_tjmax(struct cpuinfo_x86 *c, u32 id, struct device *dev)
245 /* The 100C is default for both mobile and non mobile CPUs */
248 int tjmax_ee = 85000;
253 struct pci_dev *host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0));
256 * Explicit tjmax table entries override heuristics.
257 * First try PCI host bridge IDs, followed by model ID strings
258 * and model/stepping information.
260 if (host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL) {
261 for (i = 0; i < ARRAY_SIZE(tjmax_pci_table); i++) {
262 if (host_bridge->device == tjmax_pci_table[i].device)
263 return tjmax_pci_table[i].tjmax;
267 for (i = 0; i < ARRAY_SIZE(tjmax_table); i++) {
268 if (strstr(c->x86_model_id, tjmax_table[i].id))
269 return tjmax_table[i].tjmax;
272 for (i = 0; i < ARRAY_SIZE(tjmax_model_table); i++) {
273 const struct tjmax_model *tm = &tjmax_model_table[i];
274 if (c->x86_model == tm->model &&
275 (tm->mask == ANY || c->x86_mask == tm->mask))
279 /* Early chips have no MSR for TjMax */
281 if (c->x86_model == 0xf && c->x86_mask < 4)
284 if (c->x86_model > 0xe && usemsr_ee) {
288 * Now we can detect the mobile CPU using Intel provided table
289 * http://softwarecommunity.intel.com/Wiki/Mobility/720.htm
290 * For Core2 cores, check MSR 0x17, bit 28 1 = Mobile CPU
292 err = rdmsr_safe_on_cpu(id, 0x17, &eax, &edx);
295 "Unable to access MSR 0x17, assuming desktop"
298 } else if (c->x86_model < 0x17 && !(eax & 0x10000000)) {
300 * Trust bit 28 up to Penryn, I could not find any
301 * documentation on that; if you happen to know
302 * someone at Intel please ask
306 /* Platform ID bits 52:50 (EDX starts at bit 32) */
307 platform_id = (edx >> 18) & 0x7;
310 * Mobile Penryn CPU seems to be platform ID 7 or 5
313 if (c->x86_model == 0x17 &&
314 (platform_id == 5 || platform_id == 7)) {
316 * If MSR EE bit is set, set it to 90 degrees C,
317 * otherwise 105 degrees C
326 err = rdmsr_safe_on_cpu(id, 0xee, &eax, &edx);
329 "Unable to access MSR 0xEE, for Tjmax, left"
331 } else if (eax & 0x40000000) {
334 } else if (tjmax == 100000) {
336 * If we don't use msr EE it means we are desktop CPU
337 * (with exeception of Atom)
339 dev_warn(dev, "Using relative temperature scale!\n");
345 static bool cpu_has_tjmax(struct cpuinfo_x86 *c)
347 u8 model = c->x86_model;
349 return model > 0xe &&
357 static int get_tjmax(struct cpuinfo_x86 *c, u32 id, struct device *dev)
364 * A new feature of current Intel(R) processors, the
365 * IA32_TEMPERATURE_TARGET contains the TjMax value
367 err = rdmsr_safe_on_cpu(id, MSR_IA32_TEMPERATURE_TARGET, &eax, &edx);
369 if (cpu_has_tjmax(c))
370 dev_warn(dev, "Unable to read TjMax from CPU %u\n", id);
372 val = (eax >> 16) & 0x7f;
374 * If the TjMax is not plausible, an assumption
378 dev_dbg(dev, "TjMax is %d degrees C\n", val);
384 dev_notice(dev, "TjMax forced to %d degrees C by user\n",
386 return force_tjmax * 1000;
390 * An assumption is made for early CPUs and unreadable MSR.
391 * NOTE: the calculated value may not be correct.
393 return adjust_tjmax(c, id, dev);
396 static int create_name_attr(struct platform_data *pdata,
399 sysfs_attr_init(&pdata->name_attr.attr);
400 pdata->name_attr.attr.name = "name";
401 pdata->name_attr.attr.mode = S_IRUGO;
402 pdata->name_attr.show = show_name;
403 return device_create_file(dev, &pdata->name_attr);
406 static int create_core_attrs(struct temp_data *tdata, struct device *dev,
410 static ssize_t (*const rd_ptr[TOTAL_ATTRS]) (struct device *dev,
411 struct device_attribute *devattr, char *buf) = {
412 show_label, show_crit_alarm, show_temp, show_tjmax,
414 static const char *const names[TOTAL_ATTRS] = {
415 "temp%d_label", "temp%d_crit_alarm",
416 "temp%d_input", "temp%d_crit",
419 for (i = 0; i < tdata->attr_size; i++) {
420 snprintf(tdata->attr_name[i], CORETEMP_NAME_LENGTH, names[i],
422 sysfs_attr_init(&tdata->sd_attrs[i].dev_attr.attr);
423 tdata->sd_attrs[i].dev_attr.attr.name = tdata->attr_name[i];
424 tdata->sd_attrs[i].dev_attr.attr.mode = S_IRUGO;
425 tdata->sd_attrs[i].dev_attr.show = rd_ptr[i];
426 tdata->sd_attrs[i].index = attr_no;
427 err = device_create_file(dev, &tdata->sd_attrs[i].dev_attr);
435 device_remove_file(dev, &tdata->sd_attrs[i].dev_attr);
440 static int chk_ucode_version(unsigned int cpu)
442 struct cpuinfo_x86 *c = &cpu_data(cpu);
445 * Check if we have problem with errata AE18 of Core processors:
446 * Readings might stop update when processor visited too deep sleep,
447 * fixed for stepping D0 (6EC).
449 if (c->x86_model == 0xe && c->x86_mask < 0xc && c->microcode < 0x39) {
450 pr_err("Errata AE18 not fixed, update BIOS or microcode of the CPU!\n");
456 static struct platform_device *coretemp_get_pdev(unsigned int cpu)
458 u16 phys_proc_id = TO_PHYS_ID(cpu);
459 struct pdev_entry *p;
461 mutex_lock(&pdev_list_mutex);
463 list_for_each_entry(p, &pdev_list, list)
464 if (p->phys_proc_id == phys_proc_id) {
465 mutex_unlock(&pdev_list_mutex);
469 mutex_unlock(&pdev_list_mutex);
473 static struct temp_data *init_temp_data(unsigned int cpu, int pkg_flag)
475 struct temp_data *tdata;
477 tdata = kzalloc(sizeof(struct temp_data), GFP_KERNEL);
481 tdata->status_reg = pkg_flag ? MSR_IA32_PACKAGE_THERM_STATUS :
482 MSR_IA32_THERM_STATUS;
483 tdata->is_pkg_data = pkg_flag;
485 tdata->cpu_core_id = TO_CORE_ID(cpu);
486 tdata->attr_size = MAX_CORE_ATTRS;
487 mutex_init(&tdata->update_lock);
491 static int create_core_data(struct platform_device *pdev, unsigned int cpu,
494 struct temp_data *tdata;
495 struct platform_data *pdata = platform_get_drvdata(pdev);
496 struct cpuinfo_x86 *c = &cpu_data(cpu);
501 * Find attr number for sysfs:
502 * We map the attr number to core id of the CPU
503 * The attr number is always core id + 2
504 * The Pkgtemp will always show up as temp1_*, if available
506 attr_no = pkg_flag ? 1 : TO_ATTR_NO(cpu);
508 if (attr_no > MAX_CORE_DATA - 1)
512 * Provide a single set of attributes for all HT siblings of a core
513 * to avoid duplicate sensors (the processor ID and core ID of all
514 * HT siblings of a core are the same).
515 * Skip if a HT sibling of this core is already registered.
516 * This is not an error.
518 if (pdata->core_data[attr_no] != NULL)
521 tdata = init_temp_data(cpu, pkg_flag);
525 /* Test if we can access the status register */
526 err = rdmsr_safe_on_cpu(cpu, tdata->status_reg, &eax, &edx);
530 /* We can access status register. Get Critical Temperature */
531 tdata->tjmax = get_tjmax(c, cpu, &pdev->dev);
534 * Read the still undocumented bits 8:15 of IA32_TEMPERATURE_TARGET.
535 * The target temperature is available on older CPUs but not in this
536 * register. Atoms don't have the register at all.
538 if (c->x86_model > 0xe && c->x86_model != 0x1c) {
539 err = rdmsr_safe_on_cpu(cpu, MSR_IA32_TEMPERATURE_TARGET,
543 = tdata->tjmax - ((eax >> 8) & 0xff) * 1000;
548 pdata->core_data[attr_no] = tdata;
550 /* Create sysfs interfaces */
551 err = create_core_attrs(tdata, &pdev->dev, attr_no);
557 pdata->core_data[attr_no] = NULL;
562 static void coretemp_add_core(unsigned int cpu, int pkg_flag)
564 struct platform_device *pdev = coretemp_get_pdev(cpu);
570 err = create_core_data(pdev, cpu, pkg_flag);
572 dev_err(&pdev->dev, "Adding Core %u failed\n", cpu);
575 static void coretemp_remove_core(struct platform_data *pdata,
576 struct device *dev, int indx)
579 struct temp_data *tdata = pdata->core_data[indx];
581 /* Remove the sysfs attributes */
582 for (i = 0; i < tdata->attr_size; i++)
583 device_remove_file(dev, &tdata->sd_attrs[i].dev_attr);
585 kfree(pdata->core_data[indx]);
586 pdata->core_data[indx] = NULL;
589 static int coretemp_probe(struct platform_device *pdev)
591 struct platform_data *pdata;
594 /* Initialize the per-package data structures */
595 pdata = kzalloc(sizeof(struct platform_data), GFP_KERNEL);
599 err = create_name_attr(pdata, &pdev->dev);
603 pdata->phys_proc_id = pdev->id;
604 platform_set_drvdata(pdev, pdata);
606 pdata->hwmon_dev = hwmon_device_register(&pdev->dev);
607 if (IS_ERR(pdata->hwmon_dev)) {
608 err = PTR_ERR(pdata->hwmon_dev);
609 dev_err(&pdev->dev, "Class registration failed (%d)\n", err);
615 device_remove_file(&pdev->dev, &pdata->name_attr);
621 static int coretemp_remove(struct platform_device *pdev)
623 struct platform_data *pdata = platform_get_drvdata(pdev);
626 for (i = MAX_CORE_DATA - 1; i >= 0; --i)
627 if (pdata->core_data[i])
628 coretemp_remove_core(pdata, &pdev->dev, i);
630 device_remove_file(&pdev->dev, &pdata->name_attr);
631 hwmon_device_unregister(pdata->hwmon_dev);
636 static struct platform_driver coretemp_driver = {
638 .owner = THIS_MODULE,
641 .probe = coretemp_probe,
642 .remove = coretemp_remove,
645 static int coretemp_device_add(unsigned int cpu)
648 struct platform_device *pdev;
649 struct pdev_entry *pdev_entry;
651 mutex_lock(&pdev_list_mutex);
653 pdev = platform_device_alloc(DRVNAME, TO_PHYS_ID(cpu));
656 pr_err("Device allocation failed\n");
660 pdev_entry = kzalloc(sizeof(struct pdev_entry), GFP_KERNEL);
663 goto exit_device_put;
666 err = platform_device_add(pdev);
668 pr_err("Device addition failed (%d)\n", err);
669 goto exit_device_free;
672 pdev_entry->pdev = pdev;
673 pdev_entry->phys_proc_id = pdev->id;
675 list_add_tail(&pdev_entry->list, &pdev_list);
676 mutex_unlock(&pdev_list_mutex);
683 platform_device_put(pdev);
685 mutex_unlock(&pdev_list_mutex);
689 static void coretemp_device_remove(unsigned int cpu)
691 struct pdev_entry *p, *n;
692 u16 phys_proc_id = TO_PHYS_ID(cpu);
694 mutex_lock(&pdev_list_mutex);
695 list_for_each_entry_safe(p, n, &pdev_list, list) {
696 if (p->phys_proc_id != phys_proc_id)
698 platform_device_unregister(p->pdev);
702 mutex_unlock(&pdev_list_mutex);
705 static bool is_any_core_online(struct platform_data *pdata)
709 /* Find online cores, except pkgtemp data */
710 for (i = MAX_CORE_DATA - 1; i >= 0; --i) {
711 if (pdata->core_data[i] &&
712 !pdata->core_data[i]->is_pkg_data) {
719 static void get_core_online(unsigned int cpu)
721 struct cpuinfo_x86 *c = &cpu_data(cpu);
722 struct platform_device *pdev = coretemp_get_pdev(cpu);
726 * CPUID.06H.EAX[0] indicates whether the CPU has thermal
727 * sensors. We check this bit only, all the early CPUs
728 * without thermal sensors will be filtered out.
730 if (!cpu_has(c, X86_FEATURE_DTHERM))
734 /* Check the microcode version of the CPU */
735 if (chk_ucode_version(cpu))
739 * Alright, we have DTS support.
740 * We are bringing the _first_ core in this pkg
741 * online. So, initialize per-pkg data structures and
742 * then bring this core online.
744 err = coretemp_device_add(cpu);
748 * Check whether pkgtemp support is available.
749 * If so, add interfaces for pkgtemp.
751 if (cpu_has(c, X86_FEATURE_PTS))
752 coretemp_add_core(cpu, 1);
755 * Physical CPU device already exists.
756 * So, just add interfaces for this core.
758 coretemp_add_core(cpu, 0);
761 static void put_core_offline(unsigned int cpu)
764 struct platform_data *pdata;
765 struct platform_device *pdev = coretemp_get_pdev(cpu);
767 /* If the physical CPU device does not exist, just return */
771 pdata = platform_get_drvdata(pdev);
773 indx = TO_ATTR_NO(cpu);
775 /* The core id is too big, just return */
776 if (indx > MAX_CORE_DATA - 1)
779 if (pdata->core_data[indx] && pdata->core_data[indx]->cpu == cpu)
780 coretemp_remove_core(pdata, &pdev->dev, indx);
783 * If a HT sibling of a core is taken offline, but another HT sibling
784 * of the same core is still online, register the alternate sibling.
785 * This ensures that exactly one set of attributes is provided as long
786 * as at least one HT sibling of a core is online.
788 for_each_sibling(i, cpu) {
792 * Display temperature sensor data for one HT sibling
793 * per core only, so abort the loop after one such
794 * sibling has been found.
800 * If all cores in this pkg are offline, remove the device.
801 * coretemp_device_remove calls unregister_platform_device,
802 * which in turn calls coretemp_remove. This removes the
803 * pkgtemp entry and does other clean ups.
805 if (!is_any_core_online(pdata))
806 coretemp_device_remove(cpu);
809 static int coretemp_cpu_callback(struct notifier_block *nfb,
810 unsigned long action, void *hcpu)
812 unsigned int cpu = (unsigned long) hcpu;
816 case CPU_DOWN_FAILED:
817 get_core_online(cpu);
819 case CPU_DOWN_PREPARE:
820 put_core_offline(cpu);
826 static struct notifier_block coretemp_cpu_notifier __refdata = {
827 .notifier_call = coretemp_cpu_callback,
830 static const struct x86_cpu_id __initconst coretemp_ids[] = {
831 { X86_VENDOR_INTEL, X86_FAMILY_ANY, X86_MODEL_ANY, X86_FEATURE_DTHERM },
834 MODULE_DEVICE_TABLE(x86cpu, coretemp_ids);
836 static int __init coretemp_init(void)
841 * CPUID.06H.EAX[0] indicates whether the CPU has thermal
842 * sensors. We check this bit only, all the early CPUs
843 * without thermal sensors will be filtered out.
845 if (!x86_match_cpu(coretemp_ids))
848 err = platform_driver_register(&coretemp_driver);
853 for_each_online_cpu(i)
856 #ifndef CONFIG_HOTPLUG_CPU
857 if (list_empty(&pdev_list)) {
860 goto exit_driver_unreg;
864 register_hotcpu_notifier(&coretemp_cpu_notifier);
868 #ifndef CONFIG_HOTPLUG_CPU
870 platform_driver_unregister(&coretemp_driver);
876 static void __exit coretemp_exit(void)
878 struct pdev_entry *p, *n;
881 unregister_hotcpu_notifier(&coretemp_cpu_notifier);
882 mutex_lock(&pdev_list_mutex);
883 list_for_each_entry_safe(p, n, &pdev_list, list) {
884 platform_device_unregister(p->pdev);
888 mutex_unlock(&pdev_list_mutex);
890 platform_driver_unregister(&coretemp_driver);
894 MODULE_DESCRIPTION("Intel Core temperature monitor");
895 MODULE_LICENSE("GPL");
897 module_init(coretemp_init)
898 module_exit(coretemp_exit)