1 // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
3 * Rockchip ISP1 Driver - ISP Subdevice
5 * Copyright (C) 2019 Collabora, Ltd.
7 * Based on Rockchip ISP1 driver by Rockchip Electronics Co., Ltd.
8 * Copyright (C) 2017 Rockchip Electronics Co., Ltd.
11 #include <linux/iopoll.h>
12 #include <linux/phy/phy.h>
13 #include <linux/phy/phy-mipi-dphy.h>
14 #include <linux/pm_runtime.h>
15 #include <linux/videodev2.h>
16 #include <linux/vmalloc.h>
17 #include <media/v4l2-event.h>
19 #include "rkisp1-common.h"
21 #define RKISP1_DEF_SINK_PAD_FMT MEDIA_BUS_FMT_SRGGB10_1X10
22 #define RKISP1_DEF_SRC_PAD_FMT MEDIA_BUS_FMT_YUYV8_2X8
24 #define RKISP1_ISP_DEV_NAME RKISP1_DRIVER_NAME "_isp"
27 * NOTE: MIPI controller and input MUX are also configured in this file.
28 * This is because ISP Subdev describes not only ISP submodule (input size,
29 * format, output size, format), but also a virtual route device.
33 * There are many variables named with format/frame in below code,
34 * please see here for their meaning.
35 * Cropping in the sink pad defines the image region from the sensor.
36 * Cropping in the source pad defines the region for the Image Stabilizer (IS)
38 * Cropping regions of ISP
40 * +---------------------------------------------------------+
42 * | +---------------------------------------------------+ |
43 * | | CIF_ISP_ACQ (for black level) | |
44 * | | sink pad format | |
45 * | | +--------------------------------------------+ | |
46 * | | | CIF_ISP_OUT | | |
47 * | | | sink pad crop | | |
48 * | | | +---------------------------------+ | | |
49 * | | | | CIF_ISP_IS | | | |
50 * | | | | source pad crop and format | | | |
51 * | | | +---------------------------------+ | | |
52 * | | +--------------------------------------------+ | |
53 * | +---------------------------------------------------+ |
54 * +---------------------------------------------------------+
57 static const struct rkisp1_isp_mbus_info rkisp1_isp_formats[] = {
59 .mbus_code = MEDIA_BUS_FMT_YUYV8_2X8,
60 .pixel_enc = V4L2_PIXEL_ENC_YUV,
61 .direction = RKISP1_ISP_SD_SRC,
63 .mbus_code = MEDIA_BUS_FMT_SRGGB10_1X10,
64 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
65 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW10,
66 .bayer_pat = RKISP1_RAW_RGGB,
68 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
70 .mbus_code = MEDIA_BUS_FMT_SBGGR10_1X10,
71 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
72 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW10,
73 .bayer_pat = RKISP1_RAW_BGGR,
75 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
77 .mbus_code = MEDIA_BUS_FMT_SGBRG10_1X10,
78 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
79 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW10,
80 .bayer_pat = RKISP1_RAW_GBRG,
82 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
84 .mbus_code = MEDIA_BUS_FMT_SGRBG10_1X10,
85 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
86 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW10,
87 .bayer_pat = RKISP1_RAW_GRBG,
89 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
91 .mbus_code = MEDIA_BUS_FMT_SRGGB12_1X12,
92 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
93 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW12,
94 .bayer_pat = RKISP1_RAW_RGGB,
96 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
98 .mbus_code = MEDIA_BUS_FMT_SBGGR12_1X12,
99 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
100 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW12,
101 .bayer_pat = RKISP1_RAW_BGGR,
103 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
105 .mbus_code = MEDIA_BUS_FMT_SGBRG12_1X12,
106 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
107 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW12,
108 .bayer_pat = RKISP1_RAW_GBRG,
110 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
112 .mbus_code = MEDIA_BUS_FMT_SGRBG12_1X12,
113 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
114 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW12,
115 .bayer_pat = RKISP1_RAW_GRBG,
117 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
119 .mbus_code = MEDIA_BUS_FMT_SRGGB8_1X8,
120 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
121 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW8,
122 .bayer_pat = RKISP1_RAW_RGGB,
124 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
126 .mbus_code = MEDIA_BUS_FMT_SBGGR8_1X8,
127 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
128 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW8,
129 .bayer_pat = RKISP1_RAW_BGGR,
131 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
133 .mbus_code = MEDIA_BUS_FMT_SGBRG8_1X8,
134 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
135 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW8,
136 .bayer_pat = RKISP1_RAW_GBRG,
138 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
140 .mbus_code = MEDIA_BUS_FMT_SGRBG8_1X8,
141 .pixel_enc = V4L2_PIXEL_ENC_BAYER,
142 .mipi_dt = RKISP1_CIF_CSI2_DT_RAW8,
143 .bayer_pat = RKISP1_RAW_GRBG,
145 .direction = RKISP1_ISP_SD_SINK | RKISP1_ISP_SD_SRC,
147 .mbus_code = MEDIA_BUS_FMT_YUYV8_1X16,
148 .pixel_enc = V4L2_PIXEL_ENC_YUV,
149 .mipi_dt = RKISP1_CIF_CSI2_DT_YUV422_8b,
150 .yuv_seq = RKISP1_CIF_ISP_ACQ_PROP_YCBYCR,
152 .direction = RKISP1_ISP_SD_SINK,
154 .mbus_code = MEDIA_BUS_FMT_YVYU8_1X16,
155 .pixel_enc = V4L2_PIXEL_ENC_YUV,
156 .mipi_dt = RKISP1_CIF_CSI2_DT_YUV422_8b,
157 .yuv_seq = RKISP1_CIF_ISP_ACQ_PROP_YCRYCB,
159 .direction = RKISP1_ISP_SD_SINK,
161 .mbus_code = MEDIA_BUS_FMT_UYVY8_1X16,
162 .pixel_enc = V4L2_PIXEL_ENC_YUV,
163 .mipi_dt = RKISP1_CIF_CSI2_DT_YUV422_8b,
164 .yuv_seq = RKISP1_CIF_ISP_ACQ_PROP_CBYCRY,
166 .direction = RKISP1_ISP_SD_SINK,
168 .mbus_code = MEDIA_BUS_FMT_VYUY8_1X16,
169 .pixel_enc = V4L2_PIXEL_ENC_YUV,
170 .mipi_dt = RKISP1_CIF_CSI2_DT_YUV422_8b,
171 .yuv_seq = RKISP1_CIF_ISP_ACQ_PROP_CRYCBY,
173 .direction = RKISP1_ISP_SD_SINK,
177 /* ----------------------------------------------------------------------------
181 const struct rkisp1_isp_mbus_info *rkisp1_isp_mbus_info_get(u32 mbus_code)
185 for (i = 0; i < ARRAY_SIZE(rkisp1_isp_formats); i++) {
186 const struct rkisp1_isp_mbus_info *fmt = &rkisp1_isp_formats[i];
188 if (fmt->mbus_code == mbus_code)
195 static struct v4l2_subdev *rkisp1_get_remote_sensor(struct v4l2_subdev *sd)
197 struct media_pad *local, *remote;
198 struct media_entity *sensor_me;
200 local = &sd->entity.pads[RKISP1_ISP_PAD_SINK_VIDEO];
201 remote = media_entity_remote_pad(local);
205 sensor_me = remote->entity;
206 return media_entity_to_v4l2_subdev(sensor_me);
209 static struct v4l2_mbus_framefmt *
210 rkisp1_isp_get_pad_fmt(struct rkisp1_isp *isp,
211 struct v4l2_subdev_pad_config *cfg,
212 unsigned int pad, u32 which)
214 if (which == V4L2_SUBDEV_FORMAT_TRY)
215 return v4l2_subdev_get_try_format(&isp->sd, cfg, pad);
217 return v4l2_subdev_get_try_format(&isp->sd, isp->pad_cfg, pad);
220 static struct v4l2_rect *
221 rkisp1_isp_get_pad_crop(struct rkisp1_isp *isp,
222 struct v4l2_subdev_pad_config *cfg,
223 unsigned int pad, u32 which)
225 if (which == V4L2_SUBDEV_FORMAT_TRY)
226 return v4l2_subdev_get_try_crop(&isp->sd, cfg, pad);
228 return v4l2_subdev_get_try_crop(&isp->sd, isp->pad_cfg, pad);
231 /* ----------------------------------------------------------------------------
232 * Camera Interface registers configurations
236 * Image Stabilization.
237 * This should only be called when configuring CIF
238 * or at the frame end interrupt
240 static void rkisp1_config_ism(struct rkisp1_device *rkisp1)
242 struct v4l2_rect *src_crop =
243 rkisp1_isp_get_pad_crop(&rkisp1->isp, NULL,
244 RKISP1_ISP_PAD_SOURCE_VIDEO,
245 V4L2_SUBDEV_FORMAT_ACTIVE);
248 rkisp1_write(rkisp1, 0, RKISP1_CIF_ISP_IS_RECENTER);
249 rkisp1_write(rkisp1, 0, RKISP1_CIF_ISP_IS_MAX_DX);
250 rkisp1_write(rkisp1, 0, RKISP1_CIF_ISP_IS_MAX_DY);
251 rkisp1_write(rkisp1, 0, RKISP1_CIF_ISP_IS_DISPLACE);
252 rkisp1_write(rkisp1, src_crop->left, RKISP1_CIF_ISP_IS_H_OFFS);
253 rkisp1_write(rkisp1, src_crop->top, RKISP1_CIF_ISP_IS_V_OFFS);
254 rkisp1_write(rkisp1, src_crop->width, RKISP1_CIF_ISP_IS_H_SIZE);
255 rkisp1_write(rkisp1, src_crop->height, RKISP1_CIF_ISP_IS_V_SIZE);
257 /* IS(Image Stabilization) is always on, working as output crop */
258 rkisp1_write(rkisp1, 1, RKISP1_CIF_ISP_IS_CTRL);
259 val = rkisp1_read(rkisp1, RKISP1_CIF_ISP_CTRL);
260 val |= RKISP1_CIF_ISP_CTRL_ISP_CFG_UPD;
261 rkisp1_write(rkisp1, val, RKISP1_CIF_ISP_CTRL);
265 * configure ISP blocks with input format, size......
267 static int rkisp1_config_isp(struct rkisp1_device *rkisp1)
269 u32 isp_ctrl = 0, irq_mask = 0, acq_mult = 0, signal = 0;
270 const struct rkisp1_isp_mbus_info *src_fmt, *sink_fmt;
271 struct rkisp1_sensor_async *sensor;
272 struct v4l2_mbus_framefmt *sink_frm;
273 struct v4l2_rect *sink_crop;
275 sensor = rkisp1->active_sensor;
276 sink_fmt = rkisp1->isp.sink_fmt;
277 src_fmt = rkisp1->isp.src_fmt;
278 sink_frm = rkisp1_isp_get_pad_fmt(&rkisp1->isp, NULL,
279 RKISP1_ISP_PAD_SINK_VIDEO,
280 V4L2_SUBDEV_FORMAT_ACTIVE);
281 sink_crop = rkisp1_isp_get_pad_crop(&rkisp1->isp, NULL,
282 RKISP1_ISP_PAD_SINK_VIDEO,
283 V4L2_SUBDEV_FORMAT_ACTIVE);
285 if (sink_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
287 if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
288 if (sensor->mbus_type == V4L2_MBUS_BT656)
289 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_RAW_PICT_ITU656;
291 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_RAW_PICT;
293 rkisp1_write(rkisp1, RKISP1_CIF_ISP_DEMOSAIC_TH(0xc),
294 RKISP1_CIF_ISP_DEMOSAIC);
296 if (sensor->mbus_type == V4L2_MBUS_BT656)
297 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_BAYER_ITU656;
299 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_BAYER_ITU601;
301 } else if (sink_fmt->pixel_enc == V4L2_PIXEL_ENC_YUV) {
303 if (sensor->mbus_type == V4L2_MBUS_CSI2_DPHY) {
304 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_ITU601;
306 if (sensor->mbus_type == V4L2_MBUS_BT656)
307 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_ITU656;
309 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_ITU601;
312 irq_mask |= RKISP1_CIF_ISP_DATA_LOSS;
315 /* Set up input acquisition properties */
316 if (sensor->mbus_type == V4L2_MBUS_BT656 ||
317 sensor->mbus_type == V4L2_MBUS_PARALLEL) {
318 if (sensor->mbus_flags & V4L2_MBUS_PCLK_SAMPLE_RISING)
319 signal = RKISP1_CIF_ISP_ACQ_PROP_POS_EDGE;
322 if (sensor->mbus_type == V4L2_MBUS_PARALLEL) {
323 if (sensor->mbus_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)
324 signal |= RKISP1_CIF_ISP_ACQ_PROP_VSYNC_LOW;
326 if (sensor->mbus_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)
327 signal |= RKISP1_CIF_ISP_ACQ_PROP_HSYNC_LOW;
330 rkisp1_write(rkisp1, isp_ctrl, RKISP1_CIF_ISP_CTRL);
331 rkisp1_write(rkisp1, signal | sink_fmt->yuv_seq |
332 RKISP1_CIF_ISP_ACQ_PROP_BAYER_PAT(sink_fmt->bayer_pat) |
333 RKISP1_CIF_ISP_ACQ_PROP_FIELD_SEL_ALL,
334 RKISP1_CIF_ISP_ACQ_PROP);
335 rkisp1_write(rkisp1, 0, RKISP1_CIF_ISP_ACQ_NR_FRAMES);
337 /* Acquisition Size */
338 rkisp1_write(rkisp1, 0, RKISP1_CIF_ISP_ACQ_H_OFFS);
339 rkisp1_write(rkisp1, 0, RKISP1_CIF_ISP_ACQ_V_OFFS);
341 acq_mult * sink_frm->width, RKISP1_CIF_ISP_ACQ_H_SIZE);
342 rkisp1_write(rkisp1, sink_frm->height, RKISP1_CIF_ISP_ACQ_V_SIZE);
345 rkisp1_write(rkisp1, sink_crop->left, RKISP1_CIF_ISP_OUT_H_OFFS);
346 rkisp1_write(rkisp1, sink_crop->top, RKISP1_CIF_ISP_OUT_V_OFFS);
347 rkisp1_write(rkisp1, sink_crop->width, RKISP1_CIF_ISP_OUT_H_SIZE);
348 rkisp1_write(rkisp1, sink_crop->height, RKISP1_CIF_ISP_OUT_V_SIZE);
350 irq_mask |= RKISP1_CIF_ISP_FRAME | RKISP1_CIF_ISP_V_START |
351 RKISP1_CIF_ISP_PIC_SIZE_ERROR | RKISP1_CIF_ISP_FRAME_IN;
352 rkisp1_write(rkisp1, irq_mask, RKISP1_CIF_ISP_IMSC);
354 if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
355 rkisp1_params_disable(&rkisp1->params);
357 struct v4l2_mbus_framefmt *src_frm;
359 src_frm = rkisp1_isp_get_pad_fmt(&rkisp1->isp, NULL,
360 RKISP1_ISP_PAD_SINK_VIDEO,
361 V4L2_SUBDEV_FORMAT_ACTIVE);
362 rkisp1_params_configure(&rkisp1->params, sink_fmt->bayer_pat,
363 src_frm->quantization);
369 static int rkisp1_config_dvp(struct rkisp1_device *rkisp1)
371 const struct rkisp1_isp_mbus_info *sink_fmt = rkisp1->isp.sink_fmt;
374 switch (sink_fmt->bus_width) {
376 input_sel = RKISP1_CIF_ISP_ACQ_PROP_IN_SEL_8B_ZERO;
379 input_sel = RKISP1_CIF_ISP_ACQ_PROP_IN_SEL_10B_ZERO;
382 input_sel = RKISP1_CIF_ISP_ACQ_PROP_IN_SEL_12B;
385 dev_err(rkisp1->dev, "Invalid bus width\n");
389 val = rkisp1_read(rkisp1, RKISP1_CIF_ISP_ACQ_PROP);
390 rkisp1_write(rkisp1, val | input_sel, RKISP1_CIF_ISP_ACQ_PROP);
395 static int rkisp1_config_mipi(struct rkisp1_device *rkisp1)
397 const struct rkisp1_isp_mbus_info *sink_fmt = rkisp1->isp.sink_fmt;
398 unsigned int lanes = rkisp1->active_sensor->lanes;
401 if (lanes < 1 || lanes > 4)
404 mipi_ctrl = RKISP1_CIF_MIPI_CTRL_NUM_LANES(lanes - 1) |
405 RKISP1_CIF_MIPI_CTRL_SHUTDOWNLANES(0xf) |
406 RKISP1_CIF_MIPI_CTRL_ERR_SOT_SYNC_HS_SKIP |
407 RKISP1_CIF_MIPI_CTRL_CLOCKLANE_ENA;
409 rkisp1_write(rkisp1, mipi_ctrl, RKISP1_CIF_MIPI_CTRL);
411 /* Configure Data Type and Virtual Channel */
413 RKISP1_CIF_MIPI_DATA_SEL_DT(sink_fmt->mipi_dt) |
414 RKISP1_CIF_MIPI_DATA_SEL_VC(0),
415 RKISP1_CIF_MIPI_IMG_DATA_SEL);
417 /* Clear MIPI interrupts */
418 rkisp1_write(rkisp1, ~0, RKISP1_CIF_MIPI_ICR);
420 * Disable RKISP1_CIF_MIPI_ERR_DPHY interrupt here temporary for
421 * isp bus may be dead when switch isp.
424 RKISP1_CIF_MIPI_FRAME_END | RKISP1_CIF_MIPI_ERR_CSI |
425 RKISP1_CIF_MIPI_ERR_DPHY |
426 RKISP1_CIF_MIPI_SYNC_FIFO_OVFLW(0x03) |
427 RKISP1_CIF_MIPI_ADD_DATA_OVFLW,
428 RKISP1_CIF_MIPI_IMSC);
430 dev_dbg(rkisp1->dev, "\n MIPI_CTRL 0x%08x\n"
431 " MIPI_IMG_DATA_SEL 0x%08x\n"
432 " MIPI_STATUS 0x%08x\n"
433 " MIPI_IMSC 0x%08x\n",
434 rkisp1_read(rkisp1, RKISP1_CIF_MIPI_CTRL),
435 rkisp1_read(rkisp1, RKISP1_CIF_MIPI_IMG_DATA_SEL),
436 rkisp1_read(rkisp1, RKISP1_CIF_MIPI_STATUS),
437 rkisp1_read(rkisp1, RKISP1_CIF_MIPI_IMSC));
443 static int rkisp1_config_path(struct rkisp1_device *rkisp1)
445 struct rkisp1_sensor_async *sensor = rkisp1->active_sensor;
446 u32 dpcl = rkisp1_read(rkisp1, RKISP1_CIF_VI_DPCL);
449 if (sensor->mbus_type == V4L2_MBUS_BT656 ||
450 sensor->mbus_type == V4L2_MBUS_PARALLEL) {
451 ret = rkisp1_config_dvp(rkisp1);
452 dpcl |= RKISP1_CIF_VI_DPCL_IF_SEL_PARALLEL;
453 } else if (sensor->mbus_type == V4L2_MBUS_CSI2_DPHY) {
454 ret = rkisp1_config_mipi(rkisp1);
455 dpcl |= RKISP1_CIF_VI_DPCL_IF_SEL_MIPI;
458 rkisp1_write(rkisp1, dpcl, RKISP1_CIF_VI_DPCL);
463 /* Hardware configure Entry */
464 static int rkisp1_config_cif(struct rkisp1_device *rkisp1)
469 cif_id = rkisp1_read(rkisp1, RKISP1_CIF_VI_ID);
470 dev_dbg(rkisp1->dev, "CIF_ID 0x%08x\n", cif_id);
472 ret = rkisp1_config_isp(rkisp1);
475 ret = rkisp1_config_path(rkisp1);
478 rkisp1_config_ism(rkisp1);
483 static void rkisp1_isp_stop(struct rkisp1_device *rkisp1)
488 * ISP(mi) stop in mi frame end -> Stop ISP(mipi) ->
489 * Stop ISP(isp) ->wait for ISP isp off
491 /* stop and clear MI, MIPI, and ISP interrupts */
492 rkisp1_write(rkisp1, 0, RKISP1_CIF_MIPI_IMSC);
493 rkisp1_write(rkisp1, ~0, RKISP1_CIF_MIPI_ICR);
495 rkisp1_write(rkisp1, 0, RKISP1_CIF_ISP_IMSC);
496 rkisp1_write(rkisp1, ~0, RKISP1_CIF_ISP_ICR);
498 rkisp1_write(rkisp1, 0, RKISP1_CIF_MI_IMSC);
499 rkisp1_write(rkisp1, ~0, RKISP1_CIF_MI_ICR);
500 val = rkisp1_read(rkisp1, RKISP1_CIF_MIPI_CTRL);
501 rkisp1_write(rkisp1, val & (~RKISP1_CIF_MIPI_CTRL_OUTPUT_ENA),
502 RKISP1_CIF_MIPI_CTRL);
504 val = rkisp1_read(rkisp1, RKISP1_CIF_ISP_CTRL);
505 val &= ~(RKISP1_CIF_ISP_CTRL_ISP_INFORM_ENABLE |
506 RKISP1_CIF_ISP_CTRL_ISP_ENABLE);
507 rkisp1_write(rkisp1, val, RKISP1_CIF_ISP_CTRL);
509 val = rkisp1_read(rkisp1, RKISP1_CIF_ISP_CTRL);
510 rkisp1_write(rkisp1, val | RKISP1_CIF_ISP_CTRL_ISP_CFG_UPD,
511 RKISP1_CIF_ISP_CTRL);
513 readx_poll_timeout(readl, rkisp1->base_addr + RKISP1_CIF_ISP_RIS,
514 val, val & RKISP1_CIF_ISP_OFF, 20, 100);
516 RKISP1_CIF_IRCL_MIPI_SW_RST | RKISP1_CIF_IRCL_ISP_SW_RST,
518 rkisp1_write(rkisp1, 0x0, RKISP1_CIF_IRCL);
521 static void rkisp1_config_clk(struct rkisp1_device *rkisp1)
523 u32 val = RKISP1_CIF_ICCL_ISP_CLK | RKISP1_CIF_ICCL_CP_CLK |
524 RKISP1_CIF_ICCL_MRSZ_CLK | RKISP1_CIF_ICCL_SRSZ_CLK |
525 RKISP1_CIF_ICCL_JPEG_CLK | RKISP1_CIF_ICCL_MI_CLK |
526 RKISP1_CIF_ICCL_IE_CLK | RKISP1_CIF_ICCL_MIPI_CLK |
527 RKISP1_CIF_ICCL_DCROP_CLK;
529 rkisp1_write(rkisp1, val, RKISP1_CIF_ICCL);
532 static void rkisp1_isp_start(struct rkisp1_device *rkisp1)
534 struct rkisp1_sensor_async *sensor = rkisp1->active_sensor;
537 rkisp1_config_clk(rkisp1);
540 if (sensor->mbus_type == V4L2_MBUS_CSI2_DPHY) {
541 val = rkisp1_read(rkisp1, RKISP1_CIF_MIPI_CTRL);
542 rkisp1_write(rkisp1, val | RKISP1_CIF_MIPI_CTRL_OUTPUT_ENA,
543 RKISP1_CIF_MIPI_CTRL);
546 val = rkisp1_read(rkisp1, RKISP1_CIF_ISP_CTRL);
547 val |= RKISP1_CIF_ISP_CTRL_ISP_CFG_UPD |
548 RKISP1_CIF_ISP_CTRL_ISP_ENABLE |
549 RKISP1_CIF_ISP_CTRL_ISP_INFORM_ENABLE;
550 rkisp1_write(rkisp1, val, RKISP1_CIF_ISP_CTRL);
553 * CIF spec says to wait for sufficient time after enabling
554 * the MIPI interface and before starting the sensor output.
556 usleep_range(1000, 1200);
559 /* ----------------------------------------------------------------------------
560 * Subdev pad operations
563 static int rkisp1_isp_enum_mbus_code(struct v4l2_subdev *sd,
564 struct v4l2_subdev_pad_config *cfg,
565 struct v4l2_subdev_mbus_code_enum *code)
570 if (code->pad == RKISP1_ISP_PAD_SINK_VIDEO) {
571 dir = RKISP1_ISP_SD_SINK;
572 } else if (code->pad == RKISP1_ISP_PAD_SOURCE_VIDEO) {
573 dir = RKISP1_ISP_SD_SRC;
577 code->code = MEDIA_BUS_FMT_FIXED;
581 if (code->index >= ARRAY_SIZE(rkisp1_isp_formats))
584 for (i = 0; i < ARRAY_SIZE(rkisp1_isp_formats); i++) {
585 const struct rkisp1_isp_mbus_info *fmt = &rkisp1_isp_formats[i];
587 if (fmt->direction & dir)
590 if (code->index == pos - 1) {
591 code->code = fmt->mbus_code;
599 static int rkisp1_isp_init_config(struct v4l2_subdev *sd,
600 struct v4l2_subdev_pad_config *cfg)
602 struct v4l2_mbus_framefmt *sink_fmt, *src_fmt;
603 struct v4l2_rect *sink_crop, *src_crop;
605 sink_fmt = v4l2_subdev_get_try_format(sd, cfg,
606 RKISP1_ISP_PAD_SINK_VIDEO);
607 sink_fmt->width = RKISP1_DEFAULT_WIDTH;
608 sink_fmt->height = RKISP1_DEFAULT_HEIGHT;
609 sink_fmt->field = V4L2_FIELD_NONE;
610 sink_fmt->code = RKISP1_DEF_SINK_PAD_FMT;
612 sink_crop = v4l2_subdev_get_try_crop(sd, cfg,
613 RKISP1_ISP_PAD_SINK_VIDEO);
614 sink_crop->width = RKISP1_DEFAULT_WIDTH;
615 sink_crop->height = RKISP1_DEFAULT_HEIGHT;
619 src_fmt = v4l2_subdev_get_try_format(sd, cfg,
620 RKISP1_ISP_PAD_SOURCE_VIDEO);
621 *src_fmt = *sink_fmt;
622 src_fmt->code = RKISP1_DEF_SRC_PAD_FMT;
623 src_fmt->quantization = V4L2_QUANTIZATION_FULL_RANGE;
625 src_crop = v4l2_subdev_get_try_crop(sd, cfg,
626 RKISP1_ISP_PAD_SOURCE_VIDEO);
627 *src_crop = *sink_crop;
629 sink_fmt = v4l2_subdev_get_try_format(sd, cfg,
630 RKISP1_ISP_PAD_SINK_PARAMS);
631 src_fmt = v4l2_subdev_get_try_format(sd, cfg,
632 RKISP1_ISP_PAD_SOURCE_STATS);
633 sink_fmt->width = RKISP1_DEFAULT_WIDTH;
634 sink_fmt->height = RKISP1_DEFAULT_HEIGHT;
635 sink_fmt->field = V4L2_FIELD_NONE;
636 sink_fmt->code = MEDIA_BUS_FMT_FIXED;
637 *src_fmt = *sink_fmt;
642 static void rkisp1_isp_set_src_fmt(struct rkisp1_isp *isp,
643 struct v4l2_subdev_pad_config *cfg,
644 struct v4l2_mbus_framefmt *format,
647 const struct rkisp1_isp_mbus_info *mbus_info;
648 struct v4l2_mbus_framefmt *src_fmt;
649 const struct v4l2_rect *src_crop;
651 src_fmt = rkisp1_isp_get_pad_fmt(isp, cfg,
652 RKISP1_ISP_PAD_SOURCE_VIDEO, which);
653 src_crop = rkisp1_isp_get_pad_crop(isp, cfg,
654 RKISP1_ISP_PAD_SOURCE_VIDEO, which);
656 src_fmt->code = format->code;
657 mbus_info = rkisp1_isp_mbus_info_get(src_fmt->code);
658 if (!mbus_info || !(mbus_info->direction & RKISP1_ISP_SD_SRC)) {
659 src_fmt->code = RKISP1_DEF_SRC_PAD_FMT;
660 mbus_info = rkisp1_isp_mbus_info_get(src_fmt->code);
662 if (which == V4L2_SUBDEV_FORMAT_ACTIVE)
663 isp->src_fmt = mbus_info;
664 src_fmt->width = src_crop->width;
665 src_fmt->height = src_crop->height;
666 src_fmt->quantization = format->quantization;
667 /* full range by default */
668 if (!src_fmt->quantization)
669 src_fmt->quantization = V4L2_QUANTIZATION_FULL_RANGE;
674 static void rkisp1_isp_set_src_crop(struct rkisp1_isp *isp,
675 struct v4l2_subdev_pad_config *cfg,
676 struct v4l2_rect *r, unsigned int which)
678 struct v4l2_mbus_framefmt *src_fmt;
679 const struct v4l2_rect *sink_crop;
680 struct v4l2_rect *src_crop;
682 src_crop = rkisp1_isp_get_pad_crop(isp, cfg,
683 RKISP1_ISP_PAD_SOURCE_VIDEO,
685 sink_crop = rkisp1_isp_get_pad_crop(isp, cfg,
686 RKISP1_ISP_PAD_SINK_VIDEO,
689 src_crop->left = ALIGN(r->left, 2);
690 src_crop->width = ALIGN(r->width, 2);
691 src_crop->top = r->top;
692 src_crop->height = r->height;
693 rkisp1_sd_adjust_crop_rect(src_crop, sink_crop);
697 /* Propagate to out format */
698 src_fmt = rkisp1_isp_get_pad_fmt(isp, cfg,
699 RKISP1_ISP_PAD_SOURCE_VIDEO, which);
700 rkisp1_isp_set_src_fmt(isp, cfg, src_fmt, which);
703 static void rkisp1_isp_set_sink_crop(struct rkisp1_isp *isp,
704 struct v4l2_subdev_pad_config *cfg,
705 struct v4l2_rect *r, unsigned int which)
707 struct v4l2_rect *sink_crop, *src_crop;
708 struct v4l2_mbus_framefmt *sink_fmt;
710 sink_crop = rkisp1_isp_get_pad_crop(isp, cfg, RKISP1_ISP_PAD_SINK_VIDEO,
712 sink_fmt = rkisp1_isp_get_pad_fmt(isp, cfg, RKISP1_ISP_PAD_SINK_VIDEO,
715 sink_crop->left = ALIGN(r->left, 2);
716 sink_crop->width = ALIGN(r->width, 2);
717 sink_crop->top = r->top;
718 sink_crop->height = r->height;
719 rkisp1_sd_adjust_crop(sink_crop, sink_fmt);
723 /* Propagate to out crop */
724 src_crop = rkisp1_isp_get_pad_crop(isp, cfg,
725 RKISP1_ISP_PAD_SOURCE_VIDEO, which);
726 rkisp1_isp_set_src_crop(isp, cfg, src_crop, which);
729 static void rkisp1_isp_set_sink_fmt(struct rkisp1_isp *isp,
730 struct v4l2_subdev_pad_config *cfg,
731 struct v4l2_mbus_framefmt *format,
734 const struct rkisp1_isp_mbus_info *mbus_info;
735 struct v4l2_mbus_framefmt *sink_fmt;
736 struct v4l2_rect *sink_crop;
738 sink_fmt = rkisp1_isp_get_pad_fmt(isp, cfg, RKISP1_ISP_PAD_SINK_VIDEO,
740 sink_fmt->code = format->code;
741 mbus_info = rkisp1_isp_mbus_info_get(sink_fmt->code);
742 if (!mbus_info || !(mbus_info->direction & RKISP1_ISP_SD_SINK)) {
743 sink_fmt->code = RKISP1_DEF_SINK_PAD_FMT;
744 mbus_info = rkisp1_isp_mbus_info_get(sink_fmt->code);
746 if (which == V4L2_SUBDEV_FORMAT_ACTIVE)
747 isp->sink_fmt = mbus_info;
749 sink_fmt->width = clamp_t(u32, format->width,
750 RKISP1_ISP_MIN_WIDTH,
751 RKISP1_ISP_MAX_WIDTH);
752 sink_fmt->height = clamp_t(u32, format->height,
753 RKISP1_ISP_MIN_HEIGHT,
754 RKISP1_ISP_MAX_HEIGHT);
758 /* Propagate to in crop */
759 sink_crop = rkisp1_isp_get_pad_crop(isp, cfg, RKISP1_ISP_PAD_SINK_VIDEO,
761 rkisp1_isp_set_sink_crop(isp, cfg, sink_crop, which);
764 static int rkisp1_isp_get_fmt(struct v4l2_subdev *sd,
765 struct v4l2_subdev_pad_config *cfg,
766 struct v4l2_subdev_format *fmt)
768 struct rkisp1_isp *isp = container_of(sd, struct rkisp1_isp, sd);
770 mutex_lock(&isp->ops_lock);
771 fmt->format = *rkisp1_isp_get_pad_fmt(isp, cfg, fmt->pad, fmt->which);
772 mutex_unlock(&isp->ops_lock);
776 static int rkisp1_isp_set_fmt(struct v4l2_subdev *sd,
777 struct v4l2_subdev_pad_config *cfg,
778 struct v4l2_subdev_format *fmt)
780 struct rkisp1_isp *isp = container_of(sd, struct rkisp1_isp, sd);
782 mutex_lock(&isp->ops_lock);
783 if (fmt->pad == RKISP1_ISP_PAD_SINK_VIDEO)
784 rkisp1_isp_set_sink_fmt(isp, cfg, &fmt->format, fmt->which);
785 else if (fmt->pad == RKISP1_ISP_PAD_SOURCE_VIDEO)
786 rkisp1_isp_set_src_fmt(isp, cfg, &fmt->format, fmt->which);
788 fmt->format = *rkisp1_isp_get_pad_fmt(isp, cfg, fmt->pad,
791 mutex_unlock(&isp->ops_lock);
795 static int rkisp1_isp_get_selection(struct v4l2_subdev *sd,
796 struct v4l2_subdev_pad_config *cfg,
797 struct v4l2_subdev_selection *sel)
799 struct rkisp1_isp *isp = container_of(sd, struct rkisp1_isp, sd);
802 if (sel->pad != RKISP1_ISP_PAD_SOURCE_VIDEO &&
803 sel->pad != RKISP1_ISP_PAD_SINK_VIDEO)
806 mutex_lock(&isp->ops_lock);
807 switch (sel->target) {
808 case V4L2_SEL_TGT_CROP_BOUNDS:
809 if (sel->pad == RKISP1_ISP_PAD_SINK_VIDEO) {
810 struct v4l2_mbus_framefmt *fmt;
812 fmt = rkisp1_isp_get_pad_fmt(isp, cfg, sel->pad,
814 sel->r.height = fmt->height;
815 sel->r.width = fmt->width;
819 sel->r = *rkisp1_isp_get_pad_crop(isp, cfg,
820 RKISP1_ISP_PAD_SINK_VIDEO,
824 case V4L2_SEL_TGT_CROP:
825 sel->r = *rkisp1_isp_get_pad_crop(isp, cfg, sel->pad,
831 mutex_unlock(&isp->ops_lock);
835 static int rkisp1_isp_set_selection(struct v4l2_subdev *sd,
836 struct v4l2_subdev_pad_config *cfg,
837 struct v4l2_subdev_selection *sel)
839 struct rkisp1_device *rkisp1 =
840 container_of(sd->v4l2_dev, struct rkisp1_device, v4l2_dev);
841 struct rkisp1_isp *isp = container_of(sd, struct rkisp1_isp, sd);
844 if (sel->target != V4L2_SEL_TGT_CROP)
847 dev_dbg(rkisp1->dev, "%s: pad: %d sel(%d,%d)/%dx%d\n", __func__,
848 sel->pad, sel->r.left, sel->r.top, sel->r.width, sel->r.height);
849 mutex_lock(&isp->ops_lock);
850 if (sel->pad == RKISP1_ISP_PAD_SINK_VIDEO)
851 rkisp1_isp_set_sink_crop(isp, cfg, &sel->r, sel->which);
852 else if (sel->pad == RKISP1_ISP_PAD_SOURCE_VIDEO)
853 rkisp1_isp_set_src_crop(isp, cfg, &sel->r, sel->which);
857 mutex_unlock(&isp->ops_lock);
861 static int rkisp1_subdev_link_validate(struct media_link *link)
863 if (link->sink->index == RKISP1_ISP_PAD_SINK_PARAMS)
866 return v4l2_subdev_link_validate(link);
869 static const struct v4l2_subdev_pad_ops rkisp1_isp_pad_ops = {
870 .enum_mbus_code = rkisp1_isp_enum_mbus_code,
871 .get_selection = rkisp1_isp_get_selection,
872 .set_selection = rkisp1_isp_set_selection,
873 .init_cfg = rkisp1_isp_init_config,
874 .get_fmt = rkisp1_isp_get_fmt,
875 .set_fmt = rkisp1_isp_set_fmt,
876 .link_validate = v4l2_subdev_link_validate_default,
879 /* ----------------------------------------------------------------------------
883 static int rkisp1_mipi_csi2_start(struct rkisp1_isp *isp,
884 struct rkisp1_sensor_async *sensor)
886 struct rkisp1_device *rkisp1 =
887 container_of(isp->sd.v4l2_dev, struct rkisp1_device, v4l2_dev);
888 union phy_configure_opts opts;
889 struct phy_configure_opts_mipi_dphy *cfg = &opts.mipi_dphy;
892 if (!sensor->pixel_rate_ctrl) {
893 dev_warn(rkisp1->dev, "No pixel rate control in sensor subdev\n");
897 pixel_clock = v4l2_ctrl_g_ctrl_int64(sensor->pixel_rate_ctrl);
899 dev_err(rkisp1->dev, "Invalid pixel rate value\n");
903 phy_mipi_dphy_get_default_config(pixel_clock, isp->sink_fmt->bus_width,
905 phy_set_mode(sensor->dphy, PHY_MODE_MIPI_DPHY);
906 phy_configure(sensor->dphy, &opts);
907 phy_power_on(sensor->dphy);
912 static void rkisp1_mipi_csi2_stop(struct rkisp1_sensor_async *sensor)
914 phy_power_off(sensor->dphy);
917 static int rkisp1_isp_s_stream(struct v4l2_subdev *sd, int enable)
919 struct rkisp1_device *rkisp1 =
920 container_of(sd->v4l2_dev, struct rkisp1_device, v4l2_dev);
921 struct rkisp1_isp *isp = &rkisp1->isp;
922 struct v4l2_subdev *sensor_sd;
926 rkisp1_isp_stop(rkisp1);
927 rkisp1_mipi_csi2_stop(rkisp1->active_sensor);
931 sensor_sd = rkisp1_get_remote_sensor(sd);
933 dev_warn(rkisp1->dev, "No link between isp and sensor\n");
937 rkisp1->active_sensor = container_of(sensor_sd->asd,
938 struct rkisp1_sensor_async, asd);
940 if (rkisp1->active_sensor->mbus_type != V4L2_MBUS_CSI2_DPHY)
943 atomic_set(&rkisp1->isp.frame_sequence, -1);
944 mutex_lock(&isp->ops_lock);
945 ret = rkisp1_config_cif(rkisp1);
949 ret = rkisp1_mipi_csi2_start(&rkisp1->isp, rkisp1->active_sensor);
953 rkisp1_isp_start(rkisp1);
956 mutex_unlock(&isp->ops_lock);
960 static int rkisp1_isp_subs_evt(struct v4l2_subdev *sd, struct v4l2_fh *fh,
961 struct v4l2_event_subscription *sub)
963 if (sub->type != V4L2_EVENT_FRAME_SYNC)
966 /* V4L2_EVENT_FRAME_SYNC doesn't require an id, so zero should be set */
970 return v4l2_event_subscribe(fh, sub, 0, NULL);
973 static const struct media_entity_operations rkisp1_isp_media_ops = {
974 .link_validate = rkisp1_subdev_link_validate,
977 static const struct v4l2_subdev_video_ops rkisp1_isp_video_ops = {
978 .s_stream = rkisp1_isp_s_stream,
981 static const struct v4l2_subdev_core_ops rkisp1_isp_core_ops = {
982 .subscribe_event = rkisp1_isp_subs_evt,
983 .unsubscribe_event = v4l2_event_subdev_unsubscribe,
986 static const struct v4l2_subdev_ops rkisp1_isp_ops = {
987 .core = &rkisp1_isp_core_ops,
988 .video = &rkisp1_isp_video_ops,
989 .pad = &rkisp1_isp_pad_ops,
992 int rkisp1_isp_register(struct rkisp1_device *rkisp1,
993 struct v4l2_device *v4l2_dev)
995 struct rkisp1_isp *isp = &rkisp1->isp;
996 struct media_pad *pads = isp->pads;
997 struct v4l2_subdev *sd = &isp->sd;
1000 v4l2_subdev_init(sd, &rkisp1_isp_ops);
1001 sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS;
1002 sd->entity.ops = &rkisp1_isp_media_ops;
1003 sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER;
1004 sd->owner = THIS_MODULE;
1005 strscpy(sd->name, RKISP1_ISP_DEV_NAME, sizeof(sd->name));
1007 pads[RKISP1_ISP_PAD_SINK_VIDEO].flags = MEDIA_PAD_FL_SINK |
1008 MEDIA_PAD_FL_MUST_CONNECT;
1009 pads[RKISP1_ISP_PAD_SINK_PARAMS].flags = MEDIA_PAD_FL_SINK;
1010 pads[RKISP1_ISP_PAD_SOURCE_VIDEO].flags = MEDIA_PAD_FL_SOURCE;
1011 pads[RKISP1_ISP_PAD_SOURCE_STATS].flags = MEDIA_PAD_FL_SOURCE;
1013 isp->sink_fmt = rkisp1_isp_mbus_info_get(RKISP1_DEF_SINK_PAD_FMT);
1014 isp->src_fmt = rkisp1_isp_mbus_info_get(RKISP1_DEF_SRC_PAD_FMT);
1016 mutex_init(&isp->ops_lock);
1017 ret = media_entity_pads_init(&sd->entity, RKISP1_ISP_PAD_MAX, pads);
1021 ret = v4l2_device_register_subdev(v4l2_dev, sd);
1023 dev_err(rkisp1->dev, "Failed to register isp subdev\n");
1024 goto err_cleanup_media_entity;
1027 rkisp1_isp_init_config(sd, rkisp1->isp.pad_cfg);
1030 err_cleanup_media_entity:
1031 media_entity_cleanup(&sd->entity);
1036 void rkisp1_isp_unregister(struct rkisp1_device *rkisp1)
1038 struct v4l2_subdev *sd = &rkisp1->isp.sd;
1040 v4l2_device_unregister_subdev(sd);
1041 media_entity_cleanup(&sd->entity);
1044 /* ----------------------------------------------------------------------------
1045 * Interrupt handlers
1048 void rkisp1_mipi_isr(struct rkisp1_device *rkisp1)
1052 status = rkisp1_read(rkisp1, RKISP1_CIF_MIPI_MIS);
1056 rkisp1_write(rkisp1, status, RKISP1_CIF_MIPI_ICR);
1059 * Disable DPHY errctrl interrupt, because this dphy
1060 * erctrl signal is asserted until the next changes
1061 * of line state. This time is may be too long and cpu
1062 * is hold in this interrupt.
1064 if (status & RKISP1_CIF_MIPI_ERR_CTRL(0x0f)) {
1065 val = rkisp1_read(rkisp1, RKISP1_CIF_MIPI_IMSC);
1066 rkisp1_write(rkisp1, val & ~RKISP1_CIF_MIPI_ERR_CTRL(0x0f),
1067 RKISP1_CIF_MIPI_IMSC);
1068 rkisp1->isp.is_dphy_errctrl_disabled = true;
1072 * Enable DPHY errctrl interrupt again, if mipi have receive
1073 * the whole frame without any error.
1075 if (status == RKISP1_CIF_MIPI_FRAME_END) {
1077 * Enable DPHY errctrl interrupt again, if mipi have receive
1078 * the whole frame without any error.
1080 if (rkisp1->isp.is_dphy_errctrl_disabled) {
1081 val = rkisp1_read(rkisp1, RKISP1_CIF_MIPI_IMSC);
1082 val |= RKISP1_CIF_MIPI_ERR_CTRL(0x0f);
1083 rkisp1_write(rkisp1, val, RKISP1_CIF_MIPI_IMSC);
1084 rkisp1->isp.is_dphy_errctrl_disabled = false;
1087 rkisp1->debug.mipi_error++;
1091 static void rkisp1_isp_queue_event_sof(struct rkisp1_isp *isp)
1093 struct v4l2_event event = {
1094 .type = V4L2_EVENT_FRAME_SYNC,
1098 * Increment the frame sequence on the vsync signal.
1099 * This will allow applications to detect dropped.
1100 * Note that there is a debugfs counter for dropped
1101 * frames, but using this event is more accurate.
1103 event.u.frame_sync.frame_sequence =
1104 atomic_inc_return(&isp->frame_sequence);
1105 v4l2_event_queue(isp->sd.devnode, &event);
1108 void rkisp1_isp_isr(struct rkisp1_device *rkisp1)
1110 u32 status, isp_err;
1112 status = rkisp1_read(rkisp1, RKISP1_CIF_ISP_MIS);
1116 rkisp1_write(rkisp1, status, RKISP1_CIF_ISP_ICR);
1118 /* Vertical sync signal, starting generating new frame */
1119 if (status & RKISP1_CIF_ISP_V_START)
1120 rkisp1_isp_queue_event_sof(&rkisp1->isp);
1122 if (status & RKISP1_CIF_ISP_PIC_SIZE_ERROR) {
1123 /* Clear pic_size_error */
1124 isp_err = rkisp1_read(rkisp1, RKISP1_CIF_ISP_ERR);
1125 if (isp_err & RKISP1_CIF_ISP_ERR_INFORM_SIZE)
1126 rkisp1->debug.inform_size_error++;
1127 if (isp_err & RKISP1_CIF_ISP_ERR_IS_SIZE)
1128 rkisp1->debug.img_stabilization_size_error++;
1129 if (isp_err & RKISP1_CIF_ISP_ERR_OUTFORM_SIZE)
1130 rkisp1->debug.outform_size_error++;
1131 rkisp1_write(rkisp1, isp_err, RKISP1_CIF_ISP_ERR_CLR);
1132 } else if (status & RKISP1_CIF_ISP_DATA_LOSS) {
1133 /* keep track of data_loss in debugfs */
1134 rkisp1->debug.data_loss++;
1137 if (status & RKISP1_CIF_ISP_FRAME) {
1140 /* New frame from the sensor received */
1141 isp_ris = rkisp1_read(rkisp1, RKISP1_CIF_ISP_RIS);
1142 if (isp_ris & RKISP1_STATS_MEAS_MASK)
1143 rkisp1_stats_isr(&rkisp1->stats, isp_ris);
1147 * Then update changed configs. Some of them involve
1148 * lot of register writes. Do those only one per frame.
1149 * Do the updates in the order of the processing flow.
1151 rkisp1_params_isr(rkisp1, status);