1 // SPDX-License-Identifier: GPL-2.0-only
3 * Copyright (c) 2017-2020, The Linux Foundation. All rights reserved.
6 #include <drm/drm_atomic_helper.h>
7 #include <drm/drm_atomic.h>
8 #include <drm/drm_bridge.h>
9 #include <drm/drm_bridge_connector.h>
10 #include <drm/drm_crtc.h>
17 * msm_dp_bridge_detect - callback to determine if connector is connected
18 * @bridge: Pointer to drm bridge structure
19 * Returns: Bridge's 'is connected' status
21 static enum drm_connector_status msm_dp_bridge_detect(struct drm_bridge *bridge)
25 dp = to_dp_bridge(bridge)->msm_dp_display;
27 drm_dbg_dp(dp->drm_dev, "link_ready = %s\n",
28 (dp->link_ready) ? "true" : "false");
30 return (dp->link_ready) ? connector_status_connected :
31 connector_status_disconnected;
34 static int msm_dp_bridge_atomic_check(struct drm_bridge *bridge,
35 struct drm_bridge_state *bridge_state,
36 struct drm_crtc_state *crtc_state,
37 struct drm_connector_state *conn_state)
41 dp = to_dp_bridge(bridge)->msm_dp_display;
43 drm_dbg_dp(dp->drm_dev, "link_ready = %s\n",
44 (dp->link_ready) ? "true" : "false");
47 * There is no protection in the DRM framework to check if the display
48 * pipeline has been already disabled before trying to disable it again.
49 * Hence if the sink is unplugged, the pipeline gets disabled, but the
50 * crtc->active is still true. Any attempt to set the mode or manually
51 * disable this encoder will result in the crash.
53 * TODO: add support for telling the DRM subsystem that the pipeline is
54 * disabled by the hardware and thus all access to it should be forbidden.
55 * After that this piece of code can be removed.
57 if (bridge->ops & DRM_BRIDGE_OP_HPD)
58 return (dp->link_ready) ? 0 : -ENOTCONN;
65 * msm_dp_bridge_get_modes - callback to add drm modes via drm_mode_probed_add()
66 * @bridge: Poiner to drm bridge
67 * @connector: Pointer to drm connector structure
68 * Returns: Number of modes added
70 static int msm_dp_bridge_get_modes(struct drm_bridge *bridge, struct drm_connector *connector)
78 dp = to_dp_bridge(bridge)->msm_dp_display;
80 /* pluggable case assumes EDID is read when HPD */
82 rc = msm_dp_display_get_modes(dp);
84 DRM_ERROR("failed to get DP sink modes, rc=%d\n", rc);
88 drm_dbg_dp(connector->dev, "No sink connected\n");
93 static void msm_dp_bridge_debugfs_init(struct drm_bridge *bridge, struct dentry *root)
95 struct msm_dp *dp = to_dp_bridge(bridge)->msm_dp_display;
97 msm_dp_display_debugfs_init(dp, root, false);
100 static const struct drm_bridge_funcs msm_dp_bridge_ops = {
101 .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
102 .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
103 .atomic_reset = drm_atomic_helper_bridge_reset,
104 .atomic_enable = msm_dp_bridge_atomic_enable,
105 .atomic_disable = msm_dp_bridge_atomic_disable,
106 .atomic_post_disable = msm_dp_bridge_atomic_post_disable,
107 .mode_set = msm_dp_bridge_mode_set,
108 .mode_valid = msm_dp_bridge_mode_valid,
109 .get_modes = msm_dp_bridge_get_modes,
110 .detect = msm_dp_bridge_detect,
111 .atomic_check = msm_dp_bridge_atomic_check,
112 .hpd_enable = msm_dp_bridge_hpd_enable,
113 .hpd_disable = msm_dp_bridge_hpd_disable,
114 .hpd_notify = msm_dp_bridge_hpd_notify,
115 .debugfs_init = msm_dp_bridge_debugfs_init,
118 static int msm_edp_bridge_atomic_check(struct drm_bridge *drm_bridge,
119 struct drm_bridge_state *bridge_state,
120 struct drm_crtc_state *crtc_state,
121 struct drm_connector_state *conn_state)
123 struct msm_dp *dp = to_dp_bridge(drm_bridge)->msm_dp_display;
125 if (WARN_ON(!conn_state))
128 conn_state->self_refresh_aware = dp->psr_supported;
130 if (!conn_state->crtc || !crtc_state)
133 if (crtc_state->self_refresh_active && !dp->psr_supported)
139 static void msm_edp_bridge_atomic_enable(struct drm_bridge *drm_bridge,
140 struct drm_bridge_state *old_bridge_state)
142 struct drm_atomic_state *atomic_state = old_bridge_state->base.state;
143 struct drm_crtc *crtc;
144 struct drm_crtc_state *old_crtc_state;
145 struct msm_dp_bridge *msm_dp_bridge = to_dp_bridge(drm_bridge);
146 struct msm_dp *dp = msm_dp_bridge->msm_dp_display;
149 * Check the old state of the crtc to determine if the panel
150 * was put into psr state previously by the msm_edp_bridge_atomic_disable.
151 * If the panel is in psr, just exit psr state and skip the full
152 * bridge enable sequence.
154 crtc = drm_atomic_get_new_crtc_for_encoder(atomic_state,
155 drm_bridge->encoder);
159 old_crtc_state = drm_atomic_get_old_crtc_state(atomic_state, crtc);
161 if (old_crtc_state && old_crtc_state->self_refresh_active) {
162 msm_dp_display_set_psr(dp, false);
166 msm_dp_bridge_atomic_enable(drm_bridge, old_bridge_state);
169 static void msm_edp_bridge_atomic_disable(struct drm_bridge *drm_bridge,
170 struct drm_bridge_state *old_bridge_state)
172 struct drm_atomic_state *atomic_state = old_bridge_state->base.state;
173 struct drm_crtc *crtc;
174 struct drm_crtc_state *new_crtc_state = NULL, *old_crtc_state = NULL;
175 struct msm_dp_bridge *msm_dp_bridge = to_dp_bridge(drm_bridge);
176 struct msm_dp *dp = msm_dp_bridge->msm_dp_display;
178 crtc = drm_atomic_get_old_crtc_for_encoder(atomic_state,
179 drm_bridge->encoder);
183 new_crtc_state = drm_atomic_get_new_crtc_state(atomic_state, crtc);
187 old_crtc_state = drm_atomic_get_old_crtc_state(atomic_state, crtc);
192 * Set self refresh mode if current crtc state is active.
194 * If old crtc state is active, then this is a display disable
195 * call while the sink is in psr state. So, exit psr here.
196 * The eDP controller will be disabled in the
197 * msm_edp_bridge_atomic_post_disable function.
199 * We observed sink is stuck in self refresh if psr exit is skipped
200 * when display disable occurs while the sink is in psr state.
202 if (new_crtc_state->self_refresh_active) {
203 msm_dp_display_set_psr(dp, true);
205 } else if (old_crtc_state->self_refresh_active) {
206 msm_dp_display_set_psr(dp, false);
211 msm_dp_bridge_atomic_disable(drm_bridge, old_bridge_state);
214 static void msm_edp_bridge_atomic_post_disable(struct drm_bridge *drm_bridge,
215 struct drm_bridge_state *old_bridge_state)
217 struct drm_atomic_state *atomic_state = old_bridge_state->base.state;
218 struct drm_crtc *crtc;
219 struct drm_crtc_state *new_crtc_state = NULL;
221 crtc = drm_atomic_get_old_crtc_for_encoder(atomic_state,
222 drm_bridge->encoder);
226 new_crtc_state = drm_atomic_get_new_crtc_state(atomic_state, crtc);
231 * Self refresh mode is already set in msm_edp_bridge_atomic_disable.
233 if (new_crtc_state->self_refresh_active)
236 msm_dp_bridge_atomic_post_disable(drm_bridge, old_bridge_state);
240 * msm_edp_bridge_mode_valid - callback to determine if specified mode is valid
241 * @bridge: Pointer to drm bridge structure
242 * @info: display info
243 * @mode: Pointer to drm mode structure
244 * Returns: Validity status for specified mode
246 static enum drm_mode_status msm_edp_bridge_mode_valid(struct drm_bridge *bridge,
247 const struct drm_display_info *info,
248 const struct drm_display_mode *mode)
251 int mode_pclk_khz = mode->clock;
253 dp = to_dp_bridge(bridge)->msm_dp_display;
255 if (!dp || !mode_pclk_khz || !dp->connector) {
256 DRM_ERROR("invalid params\n");
260 if (mode->clock > DP_MAX_PIXEL_CLK_KHZ)
261 return MODE_CLOCK_HIGH;
264 * The eDP controller currently does not have a reliable way of
265 * enabling panel power to read sink capabilities. So, we rely
266 * on the panel driver to populate only supported modes for now.
271 static void msm_edp_bridge_debugfs_init(struct drm_bridge *bridge, struct dentry *root)
273 struct msm_dp *dp = to_dp_bridge(bridge)->msm_dp_display;
275 msm_dp_display_debugfs_init(dp, root, true);
278 static const struct drm_bridge_funcs msm_edp_bridge_ops = {
279 .atomic_enable = msm_edp_bridge_atomic_enable,
280 .atomic_disable = msm_edp_bridge_atomic_disable,
281 .atomic_post_disable = msm_edp_bridge_atomic_post_disable,
282 .mode_set = msm_dp_bridge_mode_set,
283 .mode_valid = msm_edp_bridge_mode_valid,
284 .atomic_reset = drm_atomic_helper_bridge_reset,
285 .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
286 .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
287 .atomic_check = msm_edp_bridge_atomic_check,
288 .debugfs_init = msm_edp_bridge_debugfs_init,
291 int msm_dp_bridge_init(struct msm_dp *msm_dp_display, struct drm_device *dev,
292 struct drm_encoder *encoder, bool yuv_supported)
295 struct msm_dp_bridge *msm_dp_bridge;
296 struct drm_bridge *bridge;
298 msm_dp_bridge = devm_kzalloc(dev->dev, sizeof(*msm_dp_bridge), GFP_KERNEL);
302 msm_dp_bridge->msm_dp_display = msm_dp_display;
304 bridge = &msm_dp_bridge->bridge;
305 bridge->funcs = msm_dp_display->is_edp ? &msm_edp_bridge_ops : &msm_dp_bridge_ops;
306 bridge->type = msm_dp_display->connector_type;
307 bridge->ycbcr_420_allowed = yuv_supported;
310 * Many ops only make sense for DP. Why?
311 * - Detect/HPD are used by DRM to know if a display is _physically_
312 * there, not whether the display is powered on / finished initting.
313 * On eDP we assume the display is always there because you can't
314 * know until power is applied. If we don't implement the ops DRM will
315 * assume our display is always there.
316 * - Currently eDP mode reading is driven by the panel driver. This
317 * allows the panel driver to properly power itself on to read the
320 if (!msm_dp_display->is_edp) {
322 DRM_BRIDGE_OP_DETECT |
327 rc = devm_drm_bridge_add(dev->dev, bridge);
329 DRM_ERROR("failed to add bridge, rc=%d\n", rc);
334 rc = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
336 DRM_ERROR("failed to attach bridge, rc=%d\n", rc);
341 if (msm_dp_display->next_bridge) {
342 rc = drm_bridge_attach(encoder,
343 msm_dp_display->next_bridge, bridge,
344 DRM_BRIDGE_ATTACH_NO_CONNECTOR);
346 DRM_ERROR("failed to attach panel bridge: %d\n", rc);
354 /* connector initialization */
355 struct drm_connector *msm_dp_drm_connector_init(struct msm_dp *msm_dp_display,
356 struct drm_encoder *encoder)
358 struct drm_connector *connector = NULL;
360 connector = drm_bridge_connector_init(msm_dp_display->drm_dev, encoder);
361 if (IS_ERR(connector))
364 if (!msm_dp_display->is_edp)
365 drm_connector_attach_dp_subconnector_property(connector);
367 drm_connector_attach_encoder(connector, encoder);