1 // SPDX-License-Identifier: GPL-2.0-only
3 * Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
10 #include <linux/component.h>
11 #include <linux/mfd/syscon.h>
12 #include <linux/of_graph.h>
13 #include <linux/phy/phy.h>
14 #include <linux/pinctrl/devinfo.h>
15 #include <linux/platform_device.h>
16 #include <linux/pm_runtime.h>
17 #include <linux/regmap.h>
18 #include <linux/reset.h>
20 #include <drm/display/drm_dp_helper.h>
21 #include <drm/drm_atomic_helper.h>
22 #include <drm/drm_bridge.h>
23 #include <drm/drm_bridge_connector.h>
24 #include <drm/drm_of.h>
25 #include <drm/drm_panel.h>
26 #include <drm/drm_probe_helper.h>
27 #include <drm/drm_simple_kms_helper.h>
29 #include "rockchip_drm_drv.h"
30 #include "rockchip_drm_vop.h"
31 #include "rockchip_lvds.h"
33 #define DISPLAY_OUTPUT_RGB 0
34 #define DISPLAY_OUTPUT_LVDS 1
35 #define DISPLAY_OUTPUT_DUAL_LVDS 2
40 * struct rockchip_lvds_soc_data - rockchip lvds Soc private data
41 * @probe: LVDS platform probe function
42 * @helper_funcs: LVDS connector helper functions
44 struct rockchip_lvds_soc_data {
45 int (*probe)(struct platform_device *pdev, struct rockchip_lvds *lvds);
46 const struct drm_encoder_helper_funcs *helper_funcs;
49 struct rockchip_lvds {
55 const struct rockchip_lvds_soc_data *soc_data;
56 int output; /* rgb lvds or dual lvds output */
57 int format; /* vesa or jeida format */
58 struct drm_device *drm_dev;
59 struct drm_panel *panel;
60 struct drm_bridge *bridge;
61 struct drm_connector connector;
62 struct rockchip_encoder encoder;
63 struct dev_pin_info *pins;
66 static inline struct rockchip_lvds *connector_to_lvds(struct drm_connector *connector)
68 return container_of(connector, struct rockchip_lvds, connector);
71 static inline struct rockchip_lvds *encoder_to_lvds(struct drm_encoder *encoder)
73 struct rockchip_encoder *rkencoder = to_rockchip_encoder(encoder);
75 return container_of(rkencoder, struct rockchip_lvds, encoder);
78 static inline void rk3288_writel(struct rockchip_lvds *lvds, u32 offset,
81 writel_relaxed(val, lvds->regs + offset);
82 if (lvds->output == DISPLAY_OUTPUT_LVDS)
84 writel_relaxed(val, lvds->regs + offset + RK3288_LVDS_CH1_OFFSET);
87 static inline int rockchip_lvds_name_to_format(const char *s)
89 if (strncmp(s, "jeida-18", 8) == 0)
91 else if (strncmp(s, "jeida-24", 8) == 0)
93 else if (strncmp(s, "vesa-24", 7) == 0)
99 static inline int rockchip_lvds_name_to_output(const char *s)
101 if (strncmp(s, "rgb", 3) == 0)
102 return DISPLAY_OUTPUT_RGB;
103 else if (strncmp(s, "lvds", 4) == 0)
104 return DISPLAY_OUTPUT_LVDS;
105 else if (strncmp(s, "duallvds", 8) == 0)
106 return DISPLAY_OUTPUT_DUAL_LVDS;
111 static const struct drm_connector_funcs rockchip_lvds_connector_funcs = {
112 .fill_modes = drm_helper_probe_single_connector_modes,
113 .destroy = drm_connector_cleanup,
114 .reset = drm_atomic_helper_connector_reset,
115 .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
116 .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
119 static int rockchip_lvds_connector_get_modes(struct drm_connector *connector)
121 struct rockchip_lvds *lvds = connector_to_lvds(connector);
122 struct drm_panel *panel = lvds->panel;
124 return drm_panel_get_modes(panel, connector);
128 struct drm_connector_helper_funcs rockchip_lvds_connector_helper_funcs = {
129 .get_modes = rockchip_lvds_connector_get_modes,
133 rockchip_lvds_encoder_atomic_check(struct drm_encoder *encoder,
134 struct drm_crtc_state *crtc_state,
135 struct drm_connector_state *conn_state)
137 struct rockchip_crtc_state *s = to_rockchip_crtc_state(crtc_state);
139 s->output_mode = ROCKCHIP_OUT_MODE_P888;
140 s->output_type = DRM_MODE_CONNECTOR_LVDS;
145 static int rk3288_lvds_poweron(struct rockchip_lvds *lvds)
150 ret = clk_enable(lvds->pclk);
152 DRM_DEV_ERROR(lvds->dev, "failed to enable lvds pclk %d\n", ret);
155 ret = pm_runtime_resume_and_get(lvds->dev);
157 DRM_DEV_ERROR(lvds->dev, "failed to get pm runtime: %d\n", ret);
158 clk_disable(lvds->pclk);
161 val = RK3288_LVDS_CH0_REG0_LANE4_EN | RK3288_LVDS_CH0_REG0_LANE3_EN |
162 RK3288_LVDS_CH0_REG0_LANE2_EN | RK3288_LVDS_CH0_REG0_LANE1_EN |
163 RK3288_LVDS_CH0_REG0_LANE0_EN;
164 if (lvds->output == DISPLAY_OUTPUT_RGB) {
165 val |= RK3288_LVDS_CH0_REG0_TTL_EN |
166 RK3288_LVDS_CH0_REG0_LANECK_EN;
167 rk3288_writel(lvds, RK3288_LVDS_CH0_REG0, val);
168 rk3288_writel(lvds, RK3288_LVDS_CH0_REG2,
169 RK3288_LVDS_PLL_FBDIV_REG2(0x46));
170 rk3288_writel(lvds, RK3288_LVDS_CH0_REG4,
171 RK3288_LVDS_CH0_REG4_LANECK_TTL_MODE |
172 RK3288_LVDS_CH0_REG4_LANE4_TTL_MODE |
173 RK3288_LVDS_CH0_REG4_LANE3_TTL_MODE |
174 RK3288_LVDS_CH0_REG4_LANE2_TTL_MODE |
175 RK3288_LVDS_CH0_REG4_LANE1_TTL_MODE |
176 RK3288_LVDS_CH0_REG4_LANE0_TTL_MODE);
177 rk3288_writel(lvds, RK3288_LVDS_CH0_REG5,
178 RK3288_LVDS_CH0_REG5_LANECK_TTL_DATA |
179 RK3288_LVDS_CH0_REG5_LANE4_TTL_DATA |
180 RK3288_LVDS_CH0_REG5_LANE3_TTL_DATA |
181 RK3288_LVDS_CH0_REG5_LANE2_TTL_DATA |
182 RK3288_LVDS_CH0_REG5_LANE1_TTL_DATA |
183 RK3288_LVDS_CH0_REG5_LANE0_TTL_DATA);
185 val |= RK3288_LVDS_CH0_REG0_LVDS_EN |
186 RK3288_LVDS_CH0_REG0_LANECK_EN;
187 rk3288_writel(lvds, RK3288_LVDS_CH0_REG0, val);
188 rk3288_writel(lvds, RK3288_LVDS_CH0_REG1,
189 RK3288_LVDS_CH0_REG1_LANECK_BIAS |
190 RK3288_LVDS_CH0_REG1_LANE4_BIAS |
191 RK3288_LVDS_CH0_REG1_LANE3_BIAS |
192 RK3288_LVDS_CH0_REG1_LANE2_BIAS |
193 RK3288_LVDS_CH0_REG1_LANE1_BIAS |
194 RK3288_LVDS_CH0_REG1_LANE0_BIAS);
195 rk3288_writel(lvds, RK3288_LVDS_CH0_REG2,
196 RK3288_LVDS_CH0_REG2_RESERVE_ON |
197 RK3288_LVDS_CH0_REG2_LANECK_LVDS_MODE |
198 RK3288_LVDS_CH0_REG2_LANE4_LVDS_MODE |
199 RK3288_LVDS_CH0_REG2_LANE3_LVDS_MODE |
200 RK3288_LVDS_CH0_REG2_LANE2_LVDS_MODE |
201 RK3288_LVDS_CH0_REG2_LANE1_LVDS_MODE |
202 RK3288_LVDS_CH0_REG2_LANE0_LVDS_MODE |
203 RK3288_LVDS_PLL_FBDIV_REG2(0x46));
204 rk3288_writel(lvds, RK3288_LVDS_CH0_REG4, 0x00);
205 rk3288_writel(lvds, RK3288_LVDS_CH0_REG5, 0x00);
207 rk3288_writel(lvds, RK3288_LVDS_CH0_REG3,
208 RK3288_LVDS_PLL_FBDIV_REG3(0x46));
209 rk3288_writel(lvds, RK3288_LVDS_CH0_REGD,
210 RK3288_LVDS_PLL_PREDIV_REGD(0x0a));
211 rk3288_writel(lvds, RK3288_LVDS_CH0_REG20,
212 RK3288_LVDS_CH0_REG20_LSB);
214 rk3288_writel(lvds, RK3288_LVDS_CFG_REGC,
215 RK3288_LVDS_CFG_REGC_PLL_ENABLE);
216 rk3288_writel(lvds, RK3288_LVDS_CFG_REG21,
217 RK3288_LVDS_CFG_REG21_TX_ENABLE);
222 static void rk3288_lvds_poweroff(struct rockchip_lvds *lvds)
227 rk3288_writel(lvds, RK3288_LVDS_CFG_REG21,
228 RK3288_LVDS_CFG_REG21_TX_ENABLE);
229 rk3288_writel(lvds, RK3288_LVDS_CFG_REGC,
230 RK3288_LVDS_CFG_REGC_PLL_ENABLE);
231 val = LVDS_DUAL | LVDS_TTL_EN | LVDS_CH0_EN | LVDS_CH1_EN | LVDS_PWRDN;
233 ret = regmap_write(lvds->grf, RK3288_LVDS_GRF_SOC_CON7, val);
235 DRM_DEV_ERROR(lvds->dev, "Could not write to GRF: %d\n", ret);
237 pm_runtime_put(lvds->dev);
238 clk_disable(lvds->pclk);
241 static int rk3288_lvds_grf_config(struct drm_encoder *encoder,
242 struct drm_display_mode *mode)
244 struct rockchip_lvds *lvds = encoder_to_lvds(encoder);
245 u8 pin_hsync = (mode->flags & DRM_MODE_FLAG_PHSYNC) ? 1 : 0;
246 u8 pin_dclk = (mode->flags & DRM_MODE_FLAG_PCSYNC) ? 1 : 0;
250 /* iomux to LCD data/sync mode */
251 if (lvds->output == DISPLAY_OUTPUT_RGB)
252 if (lvds->pins && !IS_ERR(lvds->pins->default_state))
253 pinctrl_select_state(lvds->pins->p,
254 lvds->pins->default_state);
255 val = lvds->format | LVDS_CH0_EN;
256 if (lvds->output == DISPLAY_OUTPUT_RGB)
257 val |= LVDS_TTL_EN | LVDS_CH1_EN;
258 else if (lvds->output == DISPLAY_OUTPUT_DUAL_LVDS)
259 val |= LVDS_DUAL | LVDS_CH1_EN;
261 if ((mode->htotal - mode->hsync_start) & 0x01)
262 val |= LVDS_START_PHASE_RST_1;
264 val |= (pin_dclk << 8) | (pin_hsync << 9);
265 val |= (0xffff << 16);
266 ret = regmap_write(lvds->grf, RK3288_LVDS_GRF_SOC_CON7, val);
268 DRM_DEV_ERROR(lvds->dev, "Could not write to GRF: %d\n", ret);
273 static int rk3288_lvds_set_vop_source(struct rockchip_lvds *lvds,
274 struct drm_encoder *encoder)
279 ret = drm_of_encoder_active_endpoint_id(lvds->dev->of_node, encoder);
283 val = RK3288_LVDS_SOC_CON6_SEL_VOP_LIT << 16;
285 val |= RK3288_LVDS_SOC_CON6_SEL_VOP_LIT;
287 ret = regmap_write(lvds->grf, RK3288_LVDS_GRF_SOC_CON6, val);
294 static void rk3288_lvds_encoder_enable(struct drm_encoder *encoder)
296 struct rockchip_lvds *lvds = encoder_to_lvds(encoder);
297 struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;
300 drm_panel_prepare(lvds->panel);
302 ret = rk3288_lvds_poweron(lvds);
304 DRM_DEV_ERROR(lvds->dev, "failed to power on LVDS: %d\n", ret);
305 drm_panel_unprepare(lvds->panel);
309 ret = rk3288_lvds_grf_config(encoder, mode);
311 DRM_DEV_ERROR(lvds->dev, "failed to configure LVDS: %d\n", ret);
312 drm_panel_unprepare(lvds->panel);
316 ret = rk3288_lvds_set_vop_source(lvds, encoder);
318 DRM_DEV_ERROR(lvds->dev, "failed to set VOP source: %d\n", ret);
319 drm_panel_unprepare(lvds->panel);
323 drm_panel_enable(lvds->panel);
326 static void rk3288_lvds_encoder_disable(struct drm_encoder *encoder)
328 struct rockchip_lvds *lvds = encoder_to_lvds(encoder);
330 drm_panel_disable(lvds->panel);
331 rk3288_lvds_poweroff(lvds);
332 drm_panel_unprepare(lvds->panel);
335 static int px30_lvds_poweron(struct rockchip_lvds *lvds)
339 ret = pm_runtime_resume_and_get(lvds->dev);
341 DRM_DEV_ERROR(lvds->dev, "failed to get pm runtime: %d\n", ret);
345 /* Enable LVDS mode */
346 ret = regmap_update_bits(lvds->grf, PX30_LVDS_GRF_PD_VO_CON1,
347 PX30_LVDS_MODE_EN(1) | PX30_LVDS_P2S_EN(1),
348 PX30_LVDS_MODE_EN(1) | PX30_LVDS_P2S_EN(1));
350 pm_runtime_put(lvds->dev);
355 static void px30_lvds_poweroff(struct rockchip_lvds *lvds)
357 regmap_update_bits(lvds->grf, PX30_LVDS_GRF_PD_VO_CON1,
358 PX30_LVDS_MODE_EN(1) | PX30_LVDS_P2S_EN(1),
359 PX30_LVDS_MODE_EN(0) | PX30_LVDS_P2S_EN(0));
361 pm_runtime_put(lvds->dev);
364 static int px30_lvds_grf_config(struct drm_encoder *encoder,
365 struct drm_display_mode *mode)
367 struct rockchip_lvds *lvds = encoder_to_lvds(encoder);
369 if (lvds->output != DISPLAY_OUTPUT_LVDS) {
370 DRM_DEV_ERROR(lvds->dev, "Unsupported display output %d\n",
376 return regmap_update_bits(lvds->grf, PX30_LVDS_GRF_PD_VO_CON1,
377 PX30_LVDS_FORMAT(lvds->format),
378 PX30_LVDS_FORMAT(lvds->format));
381 static int px30_lvds_set_vop_source(struct rockchip_lvds *lvds,
382 struct drm_encoder *encoder)
386 vop = drm_of_encoder_active_endpoint_id(lvds->dev->of_node, encoder);
390 return regmap_update_bits(lvds->grf, PX30_LVDS_GRF_PD_VO_CON1,
391 PX30_LVDS_VOP_SEL(1),
392 PX30_LVDS_VOP_SEL(vop));
395 static void px30_lvds_encoder_enable(struct drm_encoder *encoder)
397 struct rockchip_lvds *lvds = encoder_to_lvds(encoder);
398 struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;
401 drm_panel_prepare(lvds->panel);
403 ret = px30_lvds_poweron(lvds);
405 DRM_DEV_ERROR(lvds->dev, "failed to power on LVDS: %d\n", ret);
406 drm_panel_unprepare(lvds->panel);
410 ret = px30_lvds_grf_config(encoder, mode);
412 DRM_DEV_ERROR(lvds->dev, "failed to configure LVDS: %d\n", ret);
413 drm_panel_unprepare(lvds->panel);
417 ret = px30_lvds_set_vop_source(lvds, encoder);
419 DRM_DEV_ERROR(lvds->dev, "failed to set VOP source: %d\n", ret);
420 drm_panel_unprepare(lvds->panel);
424 drm_panel_enable(lvds->panel);
427 static void px30_lvds_encoder_disable(struct drm_encoder *encoder)
429 struct rockchip_lvds *lvds = encoder_to_lvds(encoder);
431 drm_panel_disable(lvds->panel);
432 px30_lvds_poweroff(lvds);
433 drm_panel_unprepare(lvds->panel);
437 struct drm_encoder_helper_funcs rk3288_lvds_encoder_helper_funcs = {
438 .enable = rk3288_lvds_encoder_enable,
439 .disable = rk3288_lvds_encoder_disable,
440 .atomic_check = rockchip_lvds_encoder_atomic_check,
444 struct drm_encoder_helper_funcs px30_lvds_encoder_helper_funcs = {
445 .enable = px30_lvds_encoder_enable,
446 .disable = px30_lvds_encoder_disable,
447 .atomic_check = rockchip_lvds_encoder_atomic_check,
450 static int rk3288_lvds_probe(struct platform_device *pdev,
451 struct rockchip_lvds *lvds)
455 lvds->regs = devm_platform_ioremap_resource(pdev, 0);
456 if (IS_ERR(lvds->regs))
457 return PTR_ERR(lvds->regs);
459 lvds->pclk = devm_clk_get(lvds->dev, "pclk_lvds");
460 if (IS_ERR(lvds->pclk)) {
461 DRM_DEV_ERROR(lvds->dev, "could not get pclk_lvds\n");
462 return PTR_ERR(lvds->pclk);
465 lvds->pins = devm_kzalloc(lvds->dev, sizeof(*lvds->pins),
470 lvds->pins->p = devm_pinctrl_get(lvds->dev);
471 if (IS_ERR(lvds->pins->p)) {
472 DRM_DEV_ERROR(lvds->dev, "no pinctrl handle\n");
473 devm_kfree(lvds->dev, lvds->pins);
476 lvds->pins->default_state =
477 pinctrl_lookup_state(lvds->pins->p, "lcdc");
478 if (IS_ERR(lvds->pins->default_state)) {
479 DRM_DEV_ERROR(lvds->dev, "no default pinctrl state\n");
480 devm_kfree(lvds->dev, lvds->pins);
485 ret = clk_prepare(lvds->pclk);
487 DRM_DEV_ERROR(lvds->dev, "failed to prepare pclk_lvds\n");
494 static int px30_lvds_probe(struct platform_device *pdev,
495 struct rockchip_lvds *lvds)
500 ret = regmap_update_bits(lvds->grf, PX30_LVDS_GRF_PD_VO_CON1,
502 PX30_LVDS_MSBSEL(1));
507 lvds->dphy = devm_phy_get(&pdev->dev, "dphy");
508 if (IS_ERR(lvds->dphy))
509 return PTR_ERR(lvds->dphy);
511 ret = phy_init(lvds->dphy);
515 ret = phy_set_mode(lvds->dphy, PHY_MODE_LVDS);
519 return phy_power_on(lvds->dphy);
522 static const struct rockchip_lvds_soc_data rk3288_lvds_data = {
523 .probe = rk3288_lvds_probe,
524 .helper_funcs = &rk3288_lvds_encoder_helper_funcs,
527 static const struct rockchip_lvds_soc_data px30_lvds_data = {
528 .probe = px30_lvds_probe,
529 .helper_funcs = &px30_lvds_encoder_helper_funcs,
532 static const struct of_device_id rockchip_lvds_dt_ids[] = {
534 .compatible = "rockchip,rk3288-lvds",
535 .data = &rk3288_lvds_data
538 .compatible = "rockchip,px30-lvds",
539 .data = &px30_lvds_data
543 MODULE_DEVICE_TABLE(of, rockchip_lvds_dt_ids);
545 static int rockchip_lvds_bind(struct device *dev, struct device *master,
548 struct rockchip_lvds *lvds = dev_get_drvdata(dev);
549 struct drm_device *drm_dev = data;
550 struct drm_encoder *encoder;
551 struct drm_connector *connector;
552 struct device_node *remote = NULL;
553 struct device_node *port, *endpoint;
554 int ret = 0, child_count = 0;
558 lvds->drm_dev = drm_dev;
559 port = of_graph_get_port_by_id(dev->of_node, 1);
562 "can't found port point, please init lvds panel port!\n");
565 for_each_child_of_node(port, endpoint) {
567 of_property_read_u32(endpoint, "reg", &endpoint_id);
568 ret = drm_of_find_panel_or_bridge(dev->of_node, 1, endpoint_id,
569 &lvds->panel, &lvds->bridge);
571 of_node_put(endpoint);
576 DRM_DEV_ERROR(dev, "lvds port does not have any children\n");
580 DRM_DEV_ERROR(dev, "failed to find panel and bridge node\n");
585 remote = lvds->panel->dev->of_node;
587 remote = lvds->bridge->of_node;
588 if (of_property_read_string(dev->of_node, "rockchip,output", &name))
589 /* default set it as output rgb */
590 lvds->output = DISPLAY_OUTPUT_RGB;
592 lvds->output = rockchip_lvds_name_to_output(name);
594 if (lvds->output < 0) {
595 DRM_DEV_ERROR(dev, "invalid output type [%s]\n", name);
600 if (of_property_read_string(remote, "data-mapping", &name))
601 /* default set it as format vesa 18 */
602 lvds->format = LVDS_VESA_18;
604 lvds->format = rockchip_lvds_name_to_format(name);
606 if (lvds->format < 0) {
607 DRM_DEV_ERROR(dev, "invalid data-mapping format [%s]\n", name);
612 encoder = &lvds->encoder.encoder;
613 encoder->possible_crtcs = drm_of_find_possible_crtcs(drm_dev,
616 ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_LVDS);
618 DRM_DEV_ERROR(drm_dev->dev,
619 "failed to initialize encoder: %d\n", ret);
623 drm_encoder_helper_add(encoder, lvds->soc_data->helper_funcs);
624 connector = &lvds->connector;
627 connector->dpms = DRM_MODE_DPMS_OFF;
628 ret = drm_connector_init(drm_dev, connector,
629 &rockchip_lvds_connector_funcs,
630 DRM_MODE_CONNECTOR_LVDS);
632 DRM_DEV_ERROR(drm_dev->dev,
633 "failed to initialize connector: %d\n", ret);
634 goto err_free_encoder;
637 drm_connector_helper_add(connector,
638 &rockchip_lvds_connector_helper_funcs);
640 ret = drm_bridge_attach(encoder, lvds->bridge, NULL,
641 DRM_BRIDGE_ATTACH_NO_CONNECTOR);
643 goto err_free_encoder;
645 connector = drm_bridge_connector_init(lvds->drm_dev, encoder);
646 if (IS_ERR(connector)) {
647 DRM_DEV_ERROR(drm_dev->dev,
648 "failed to initialize bridge connector: %pe\n",
650 ret = PTR_ERR(connector);
651 goto err_free_encoder;
655 ret = drm_connector_attach_encoder(connector, encoder);
657 DRM_DEV_ERROR(drm_dev->dev,
658 "failed to attach encoder: %d\n", ret);
659 goto err_free_connector;
662 pm_runtime_enable(dev);
669 drm_connector_cleanup(connector);
671 drm_encoder_cleanup(encoder);
680 static void rockchip_lvds_unbind(struct device *dev, struct device *master,
683 struct rockchip_lvds *lvds = dev_get_drvdata(dev);
684 const struct drm_encoder_helper_funcs *encoder_funcs;
686 encoder_funcs = lvds->soc_data->helper_funcs;
687 encoder_funcs->disable(&lvds->encoder.encoder);
688 pm_runtime_disable(dev);
689 drm_connector_cleanup(&lvds->connector);
690 drm_encoder_cleanup(&lvds->encoder.encoder);
693 static const struct component_ops rockchip_lvds_component_ops = {
694 .bind = rockchip_lvds_bind,
695 .unbind = rockchip_lvds_unbind,
698 static int rockchip_lvds_probe(struct platform_device *pdev)
700 struct device *dev = &pdev->dev;
701 struct rockchip_lvds *lvds;
702 const struct of_device_id *match;
708 lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL);
713 match = of_match_node(rockchip_lvds_dt_ids, dev->of_node);
716 lvds->soc_data = match->data;
718 lvds->grf = syscon_regmap_lookup_by_phandle(dev->of_node,
720 if (IS_ERR(lvds->grf)) {
721 DRM_DEV_ERROR(dev, "missing rockchip,grf property\n");
722 return PTR_ERR(lvds->grf);
725 ret = lvds->soc_data->probe(pdev, lvds);
727 DRM_DEV_ERROR(dev, "Platform initialization failed\n");
731 dev_set_drvdata(dev, lvds);
733 ret = component_add(&pdev->dev, &rockchip_lvds_component_ops);
735 DRM_DEV_ERROR(dev, "failed to add component\n");
736 clk_unprepare(lvds->pclk);
742 static void rockchip_lvds_remove(struct platform_device *pdev)
744 struct rockchip_lvds *lvds = platform_get_drvdata(pdev);
746 component_del(&pdev->dev, &rockchip_lvds_component_ops);
747 clk_unprepare(lvds->pclk);
750 struct platform_driver rockchip_lvds_driver = {
751 .probe = rockchip_lvds_probe,
752 .remove_new = rockchip_lvds_remove,
754 .name = "rockchip-lvds",
755 .of_match_table = rockchip_lvds_dt_ids,